[BUG]: Current documentation still refers to outdated 'path' in Middleware options instead of the new `pathPrefix` about webhooks.js HOT 5 CLOSED

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

from webhooks.js.

The documentation for this repository is correct. The webhooks middleware expects a full path.

As for @octokit/app it expects a path prefix as described in its documentation.

from webhooks.js.

I updated my comment - createNodeMiddleware(app) uses a pathPrefix, and createNodeMiddleware(app.webhooks) from this library uses path. This is very confusing and should standardize on one or the either IMO.

from webhooks.js.

Why are octokit/webhooks and octokit/app different?

from webhooks.js.

It shouldn't be as you aren't using the webhooks middleware at all if you are using the @octokit/app package.

It exports a middleware that incorporates the webhooks and oauth middlewares.

It's a separate package that has separate options.

This is how it always was implemented in this package, since 11.2.0

from webhooks.js.