Giter Club home page Giter Club logo

Comments (4)

wolfy1339 avatar wolfy1339 commented on June 2, 2024

Deno support is currently an issue for all Octokit modules.

We can try to fix some bugs and get some functionality working, but the proper solution will be when we rewrite all the modules as ESM native.

from webhooks.js.

yardenshoham avatar yardenshoham commented on June 2, 2024

Gotcha, I ended up making it somewhat work with:

import { createEventHandler } from "https://esm.sh/@octokit/[email protected]";
import { serve } from "https://deno.land/[email protected]/http/server.ts";

const secret = "mysecret";
const eventHandler = createEventHandler({ secret });
eventHandler.onAny(({ id, name, payload }) => {
  console.log(name, "event received");
});

serve(async (req: Request) => {
  if (req.url.endsWith("/webhooks")) {
    eventHandler.receive({
      id: req.headers.get("x-github-delivery"),
      name: req.headers.get("x-github-event"),
      payload: await req.json(),
    });
    return Response.json({
      message:
        "Triggered webhook",
    });
  } else {
    return Response.json({ status: "OK" });
  }
}, { port: 3000 });

from webhooks.js.

josephwynn-sc avatar josephwynn-sc commented on June 2, 2024

I know this issue has been closed, but currently createNodeMiddleware() cannot be used in Deno because the Deno core team don't want to support setTimeout() returning an object. Would you be amenable to a small patch that removed the use of setTimeout().unref() so that createNodeMiddleware() worked in Deno?

from webhooks.js.

gr2m avatar gr2m commented on June 2, 2024

Would you be amenable to a small patch that removed the use of setTimeout().unref() so that createNodeMiddleware() worked in Deno?

sure! I don't see a disadvantage. I hope I don't miss anything 😬

Longer term we want to move the create*Middleware into dedicated packages, as they introduce lots of dependencies and are often times not universal, like in this case.

from webhooks.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.