Giter Club home page Giter Club logo

Comments (4)

lincolnthree avatar lincolnthree commented on June 22, 2024

Thanks! One way to find out -- If you can confirm it is broken and needs to be fixed, then we can fix it :) Otherwise, these translations were provided by users that (at least in theory) use those locales, so I assume it is working for them.

from prettytime.

MenoData avatar MenoData commented on June 22, 2024

Well, I am not willing to buy the original ISO-paper but following source seems to be more official and confirms "id" instead of "in" as well as "uk" instead of "ua":

http://www.loc.gov/standards/iso639-2/php/code_list.php

The code "ua" is obviously not the language code but the ISO-3166-country code (and should rather be in capital letters). Anyway, for new users the ISO standard should probably be the normative reference (and people will usually look there finding "uk" - or "uk_UA"), but for backward compatibility reasons you might consider to continue support for "ua".

from prettytime.

MenoData avatar MenoData commented on June 22, 2024

About Indonesian: Although "id" is definitely more correct than "in" (latter form is just an outdated identifier), current behaviour is okay because Java automatically changes any input "id" to "in" in the constructors of java.util.Locale (I assume that was for preserving backwards compatibility).

But the case of Ukrainian is definitely a bug. Right is "uk".

from prettytime.

lincolnthree avatar lincolnthree commented on June 22, 2024

Fixed Ukraine. Thanks!

from prettytime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.