Giter Club home page Giter Club logo

Comments (5)

lincolnthree avatar lincolnthree commented on June 26, 2024

Hey @dstutz thanks for the issue. Short answer, yes, but I don't have a ton of time at the moment. I would welcome a PR for this, which would make it much easier to put out a new version quickly. In the mean time it's fairly simple to create a converter:

You can use this as a guide, then register it using @FacesConverter or via faces-config.xml:
https://github.com/ocpsoft/prettytime/blob/master/jsf/src/main/java/org/ocpsoft/prettytime/jsf/PrettyTimeConverter.java
https://github.com/ocpsoft/prettytime/blob/master/jsf/src/main/resources/META-INF/faces-config.xml

Let me know if this helps?

from prettytime.

dstutz avatar dstutz commented on June 26, 2024

Yup, that is almost effortless to do on my own.

As far as a PR, again, doesn't seem like much work so I cloned the repo and I get test failures on core module (internationalization tests) attempting to build master (and 5.0.7.Final). I tried on 2 different machines:

Windows 10 - openjdk version "17.0.7" 2023-04-18
OpenJDK Runtime Environment Temurin-17.0.7+7 (build 17.0.7+7)
OpenJDK 64-Bit Server VM Temurin-17.0.7+7 (build 17.0.7+7, mixed mode, sharing)
Tests run: 1116, Failures: 121, Errors: 0, Skipped: 6

Gentoo Linux - openjdk version "17.0.6" 2023-01-17
OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10)
OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode, sharing)
Tests run: 1116, Failures: 154, Errors: 0, Skipped: 6

I'm assuming I'm missing something here...

from prettytime.

lincolnthree avatar lincolnthree commented on June 26, 2024

Sorry for the delay. Summer stuff... That's weird. Send the PR and I'll check it out. I think JDK 8 compilation works. But something changed in 11+ that makes some of the micro-time stamps higher precision and we haven't accounted for that (the outputs of the lib are still accurate). But tests freak out.

from prettytime.

csyperski avatar csyperski commented on June 26, 2024

Has a Jakarta version been released? Everything I'm seeing still references Javax.faces.context.*

from prettytime.

lincolnthree avatar lincolnthree commented on June 26, 2024

Haven't gotten the PR on this yet, but would love to get this done! If someone wants to get it started and switch over all the imports. I'll try to take it over the finish line.

from prettytime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.