Add support for dual grammatical number about prettytime HOT 3 CLOSED

Hey Katafractari!

That's awesome :)

This is very timely - I actually just implemented support for this feature in 2.0-SNAPSHOT. You can see the details of how this works in the link below. It's currently not the nicest API, because there isn't much done to simplify things (you can't simplify much when you are dealing with complex grammar rules.

Take a look:
https://github.com/ocpsoft/prettytime/blob/master/src/test/java/org/ocpsoft/pretty/time/i18n/TimeFormatProviderTest.java
https://github.com/ocpsoft/prettytime/blob/master/src/test/java/org/ocpsoft/pretty/time/i18n/Resources_xx.java

You'll need to make sure that your Resources_SL?.java bundle implements TimeFormatProvider, then for each time unit (look in the org.ocpsoft.pretty.time.units package, you'll need to either make sure that unit has Resource keys configured - like most other bundles - or return a TimeFormat for that Unit in the getFormatFor(TimeUnit t) method. You may want to set up some convenience methods to make this simpler if you plan on implementing many time formats. Or you could simply create a class extending from TimeFormat that knows about the rules you need, and pass in the right inputs for each time-unit.

What do you think?

This is a new API so I'm interested in feedback! (I'm always interested in feedback!)

~Lincoln

from prettytime.

Thanks for a quick reply. That's very nice to hear, I will probably take a look at the API by end of the week. I've just forked the project for now.

Rok

from prettytime.

Excellent, should we close this for now? If the API doesn't do what you need we can re-open it. Otherwise, I'm looking forward to seeing your pull request! Feel free to visit the forums if you have any questions: http://ocpsoft.org/support/

from prettytime.