Giter Club home page Giter Club logo

modui_classic's People

Contributors

eke00372 avatar obble avatar quiqua avatar wtfblub avatar xaero252 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

modui_classic's Issues

Cooldowns on eneny frame

Can you add cooldowns for debuffs on target frame like gouge etc?
I tryed omnicc but it doesn't work.

Would love this pack for classic

So i tried also downloading the pack for the stress-test, sadly it didnt work i would love if you "obble" could bring this back to life, its probably the best pack out there.

Unit frame auras disappearing after latest update

It seems that after some time, the aura icons under unit frames are disappearing. Reloading UI resolves the issue.

Also hate to be that guy, but I vastly prefer the old nameplate combo point display. Any chance of being able to toggle back to the old version?

Thanks

ActionBars from 1.12

heey ;-) I use your addon over years on private servers and love it ! but i got one question.

is it possible that you can put in the option that the actions bars from the right side are in the middle too ? like in this picture?

sorry for my bad english :D

WoWScrnShot_011618_000729

Few issues and requests

Heya obble

Glad to see that this god tier addon is making it to Classic. Tried the current version real quick before the stress test shut down and saw a few minor issue. First one that I noticed is that when using original actionbar (not bfa edition) the bags, except for bagpack, are scaled down as can be seen here: image
Another issue is that the addon is colliding with TinyTooltip addon. I was getting an error saying that a problem occured at line 138 in modui\tooltip\content.lua. I thought I took a screenshot of the error but I must've forgotten.

These are the only issue I experienced so far. Other than that I only have a few requests; I'd love if you could add the glow/highlight border around spell/ability icons when they are clicked, just like in the 1.12.1 version. Also would be nice if you could give icons the darker (black?) border again just like in 1.12.1 version, instead of their current grey/silver border.
I just read that you are going to make this addon pretty similar to the original so chances are that you already plan to do these things.

Anyway, thanks for your hard work. Keep it up! :-)

Pet Bar Clipping

Pet bar is clipping, as seen in the screen shot.

Also, is there a way to make the action bar icon/buff icon borders darker?
WoWScrnShot_081219_023158

Transparent name background & remove name colorize

Can we have an option to remove name background texture? And also stop colorizing name to leave it like (1, 0.8, 0) (also like an option)? For me, with this options unitframes become amazing. I did it in my fork but you make a lot of stuff today so I dont have time to rebase fork. Can provide you a screenshot of how it will look after those changes.
Amazing addong btw

Energy Bar

Is it possible to have an addon with separated energy bar and nothing more? And to make it start immediately after login, because right now it starts only after you've been in combat
I love how this meter works and find it extremely useful and I don't really need other mod features
It'll be great if you separate it

Thanks!

Request : Raid Frames

Hello,

Thanks for your great UI !

Do you have an ETA for Raid Frames ?

Thanks a lots :)

Old modui-vanilla

Possible to incorperate a lot of what you did with the old modui (maybe include the ImprovedUnitFrames - addon which works nicely with yours !

Have the options like onebag, on/off
and all the awesome shit youdid. Especially the Raid Frames.

If it doesnt come out on release - is it possible to copy parts of the old modui (like raid frames nd such) into this new folder ? or no.

Amazing work man!!!

love to help, give ideas. been using this since day one, on every char/server

Andoido#0218

1.12 modui action bar UI

Will this sort of UI be doable in the classic add-on (from your 1.12 modui) - namely the black borders around individual spell icons in the action bar.

Been playing around with the new classic add on and couldn't get it to function the same way the old modui did in regards to this.

image

Healthbar, Powerbar and Class Color change options

Hey, I was wondering if it's possible to change the colors of healthbars, powerbars and class colors? Sorry if it's already a possibility, dont have the beta so i'm not able to test the addon. The addon looks great so far tho! but if it's not possible to change the colors as i mentioned, then it would be a nice additional feature imo. I'm not the biggest fan of the default health color, and i asume there are more people who dont like it aswell. I prefere a different color darker green healthbar for example. Some may prefer a grey one etc.

Issue with another addon (TinyTooltip)

As a user, when I install ModUI, it stretches the UI of another addon (which is TinyTooltip). After disabling it, TinyTooltip is displayed as expected.

UI Colors doesn't load properly

When I change the UI Color from ModUI Menu, they don't load properly when I relog. If I go to the color settings I can see that they have the correct value that I set them to, but it doesn't load except if I move the sliders again.

(sorry)! Obble

Im wondering if you could get in contact with me -
Andoido#0218

Huge fan. I have a Lot of suggestions that you could maybe implement to improve Modui. Ive made my own edits for my own version and figured id atleast ask if you would hear me out!

Sorry last time ill post.
Please bring back the raid frames, and the old "unit frames - except with debuff timmers!!)

Request: Simplified health/power numbers

Hey!

With simplified I mean 80 instead of 80/100 energy for example, or 1325 instead of 1325/2308 health. See screenshot:

WoWScrnShot_090319_231922

I've got this working for myself, but it's spewing out errors and I had to make modifications to mod UI. It would be nice if this was not needed, or even better if this was added as an option!

To get this to work I wrote this little addon (with support for Real Mob health):

local UnitHealth = UnitHealth
local realUnitHealth = UnitHealth
local UnitHealthMax = UnitHealthMax
local realUnitHealthMax = UnitHealthMax

if RealMobHealth and RealMobHealth.GetUnitHealth then
	UnitHealth = function(unit)
		local hp = RealMobHealth.GetUnitHealth(unit, true)
		return hp or realUnitHealth(unit)
	end
	UnitHealthMax = function(unit)
		local _,maxhp = RealMobHealth.GetUnitHealth(unit, true)
		return maxhp or realUnitHealthMax(unit)
	end
elseif RealMobHealth then -- maintain compatibility for now
	UnitHealth = function(unit)
		local hp = RealMobHealth.GetHealth(unit, true)
		return hp or realUnitHealth(unit)
	end
	UnitHealthMax = function(unit)
		local _,maxhp = RealMobHealth.GetHealth(unit, true)
		return maxhp or realUnitHealthMax(unit)
	end
end

hooksecurefunc("TextStatusBar_UpdateTextStringWithValues", function()
	PlayerFrameHealthBar.TextString:SetText(AbbreviateLargeNumbers(UnitHealth("player")))
	PlayerFrameManaBar.TextString:SetText(AbbreviateLargeNumbers(UnitPower("player")))

	TargetFrameHealthBar.TextString:SetText(AbbreviateLargeNumbers(UnitHealth("target")))
	TargetFrameManaBar.TextString:SetText(AbbreviateLargeNumbers(UnitPower("target")))
end) 

but you should probably not use this because it generates a lot of Lua errors (still working good though).

It works fine, but the font on the target's powerbar is wrong. I fixed that using this change:
ollema@e616f5f

Not 100% sure on the coordinates in the y-axis.


Again, this would be really nice to have, and it's probably much easier for you (I have never written a line of lua before today!) than it is for me!

Let me know if I can provide any more details

UI Colour & Saved Variable issues

I realise this is a work in progress, and for that I thank you. I get an entirely blank window when selecting ModUI Elements, and have no minimap icon.

Should I be expecting these? Or is it simply not ready yet? Thanks!

Feature request: Energy ticks

Hey mate!
Can you add the feature to see energy ticks on the energy bar, like in the vanilla modui addon. Was really handy and missing that feature so much!:)
Thanks in advance!

No /modui command

Really appreciate your work on this addon! I was not able to get the classic version working in the stress test today on the non-beta Classic WoW client. It did move some of the UI around, but was not able to configure the addon in any way (at least that I could find.) No /modui command or 'M' button was present.

PetBar Position

Hey there! First, Thank you for this addon and the effort to keep it updated.

The issue is about the position of the PetBar anytime the ui is reloaded (ingame portal, flight path, etc.). The PetBar is loaded behind the BottomLeftActionBar. To solve the issue we have to go into ActionBars Settings (Game Settings) and disable > enable any bar. This a minor bug, I know, but is really annoying after some time.

Thanks for your time.

LUA Error

Message: Interface\AddOns\modui_classic\skin/skin.lua:29: attempt to index global 'MainMenuBarArtFrameBackground' (a nil value)
Time: Tue Jul 2 21:53:21 2019
Count: 1
Stack: Interface\AddOns\modui_classic\skin/skin.lua:29: attempt to index global 'MainMenuBarArtFrameBackground' (a nil value)
Interface\AddOns\modui_classic\skin/skin.lua:29: in main chunk

Locals: _ = "modui_classic"
addon =

{
colour =
{
}
}
f = {
0 =
}
(*temporary) =
{
}
(*temporary) = MinimapBorder {
0 =
}
(*temporary) = MiniMapTrackingBorder {
0 =
}
(*temporary) = MiniMapMailBorder {
0 =
}
(*temporary) = MiniMapBattlefieldBorder {
0 =
}
(*temporary) = PlayerFrameTexture {
0 =
}
(*temporary) = TargetFrameTextureFrameTexture {
0 =
}
(*temporary) = PetFrameTexture {
0 =
}
(*temporary) = PartyMemberFrame1Texture {
0 =
}
(*temporary) = PartyMemberFrame2Texture {
0 =
}
(*temporary) = PartyMemberFrame3Texture {
0 =
}
(*temporary) = PartyMemberFrame4Texture {
0 =
}
(*temporary) = PartyMemberFrame1PetFrameTexture {
0 =
}
(*temporary) = PartyMemberFrame2PetFrameTexture {
0 =
}
(*temporary) = PartyMemberFrame3PetFrameTexture {
0 =
}
(*temporary) = PartyMemberFrame4PetFrameTexture {
0 =
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'MainMenuBarArtFrameBackground' (a nil value)"

Non-BFA xp bar

When I disable the BFA styling action bar, the default xp bar shows instead of the nice looking one.

Is it supposed to be like that, and if so is there way to change it?

colour.lua error

Not sure if you're aware of this.
Trying to configure addons in sandbox while in queue and I really enjoy your UI's ^^

Here's the buggrabber report:

`32x modui_classic\core/colour.lua:33: attempt to index field 'statusbar' (a nil value)
modui_classic\core/colour.lua:33: in function <modui_classic\core/colour.lua:31>
modui_classic\core/colour.lua:109: in function <modui_classic\core/colour.lua:108>

Locals:
(*temporary) =

{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
7 =
{
}
8 =
{
}
9 =
{
}
11 =
{
}
13 =
{
}
PAIN =
{
}
STAGGER =
{
}
COMBO_POINTS =
{
}
FOCUS =
{
}
18 =
{
}
RUNES =
{
}
HAPPINESS =
{
}
ENERGY =
{
}
MANA =
{
}
CHI =
{
}
17 =
{
}
FURY =
{
}
HOLY_POWER =
{
}
AMMOSLOT =
{
}
INSANITY =
{
}
SOUL_SHARDS =
{
}
RUNIC_POWER =
{
}
MAELSTROM =
{
}
0 =
{
}
FUEL =
{
}
LUNAR_POWER =
{
}
ARCANE_CHARGES =
{
}
RAGE =
{
}
}
(*temporary) =
{
}
(*temporary) = nil
(*temporary) = "attempt to index field 'statusbar' (a nil value)"
`

Beta Bugs

Greetings Obble,

I've discovered 2 bugs while using your UI in the closed beta this week:

  1. Stance Bar Fixed Position
    The stance bar (or special action bar, not sure exactly what its called) is being set in a fixed position assuming the user has enabled all 3 action bars. With only 1 or 2 action bars enabled the stance bar is not aligned with the actionbar UI, and looks like its floating in space. See my screenshot below:

WoWScrnShot_081319_223244

  1. Buff / Debuff Auras

I've run into a couple of issues with buff / debuff implementation. First, debuff auras are not displaying for me. They do appear correctly for the target unitframe, but not in the main upper right area of the UI. I was in beta and got one of the annoying 10min disease debuffs and noticed nothing was displayed until I clicked on myself and saw it in the target unit frame. I was able to workaround this by disabling the Aura module. I've also noticed some inconsistencies with poisons on rogue weapons not appearing, but haven't been able yet to reproduce.

Thanks for taking the time and porting this UI over to classic, I love the simplicity and feel of this UI in classic.

Ambiguous combo points issues

Sometimes the nameplate combo points are getting bugged, showing all the colour varieties between combo point levels and one cannot recognize how many combo points are applied.

Examples shown below

ambiguous2

P.S. You've done great work so far and I'd like to contribute to your hard work. Is there a service you use for donations?

OneBag

Hey PRO
https://i.imgur.com/Qk4U4dG.jpg

Just a heads up =D you fixed the issue, looks good so far, however OneBag - no on off optioon,
also, i can "open: the bags": but i cannot "Close" the bags.

Also - what happend to your sexy cast bar =(

Debuff timer & fade

Hey,
We got aura effects(dots) on nameplates right now. Big thanks for it.
Can we have a pulsing fade & debuff timer on nameplates with lovely icons that we have right now? Thanks for your work.
That was at version 1.21.1 оf Vanilla mod UI as I remember, but not sure... If not, that will be a great addition, if its possible :)
Example dot timers from plate buff addon: image

Aura Bug (Target Frame)

The PetBar bug was solved (thank you), but after last update I found a new bug. The auras (debuff or buff) on Target Frame don't show or don't get update eventually, even after I change target. The only solution I found /reloadui.

Moving Frames

Awesome, that u bring your addon to 1.13.x. Using it since Elysium.

Not sure if, but currently I can not move frames.

A setting to keep showing up error texts

Currently it would seem the addon is disabling the blizzard error texts, ie. "Not enough rage" or insufficient skill levels on mining etc. It would be nice if this could be turned off and leave the error messages to be shown.

Toggle for classic vs bfa style action bars

Hello Obble,

First let me start with thank you for the great addon! I was wondering it you could add a toggle to switch between the classic style action bars and the bfa style compact action bars. Personally I prefer the classic action bars and I'm sure others do as well.

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.