obaidrustemi / capstone-7.2-team2 Goto Github PK

DB Issues

1. It seems we are missing a lot of columns here. I'm literally only seeing artwork but from reading your user stories it seems you should have a few more tables, particularly users, galleries, gallery_contacts, artist_contacts, etc.
2. Your users will likely need a way to differentiate between their differentiate between their roles. For example, you may want to have booleans like is_artist or is_gallery_owner to signify whether or not they are an artist, a gallery owner, or both.
3. On your artworks model (remember the convention is that this should be plural), I see you are adding columns for the artist information. Remember we shouldn't be doing this. An artwork instance should simply have an artist_id which points to an instance of users that will contain all that information (name, etc.). Also, once we do that we can also probably eliminate artwork_* in the naming of the columns.
4. Overall, I feel like your database hasn't bee fully fleshed out yet. I want to take the time here to emphasize the CRIITICAL IMPORTANCE of having a well designed and thought out database, and hope you halt work on what you've started thus far and really put some effort into planning this part of your project.

Backend Routes Issues

1. Theres a lot of columns that don't currently exist that I think we can agree probably should at this point, so clearly we should revisit this...
2. Artwork has a delete route. Unless we are going to add a user story for someone being able to purchase a piece of art from the artist, this is probably not necessary.

Frontend Routes Issues

1. Again a lot missing here so this is not very helpful to you yet. I would highly suggest putting some time into crafting these once you have a working model for your database and backend.
2. Why is there a route for POST /artwork/:id ? Certainly this shouldn't exist right?
3. Also, lets discuss why we should or would want to delete artwork....

Timeline Issues

• Timeline seems reasonably planned out. Good job!

Wireframes
-Looks good! Excited to see the finished product.