oasisdex / oasis-direct Goto Github PK

Remove popup events :

Hey guys,

I am finished up the first design mockups for oasis.direct on mobile.

Starter Page

Finalize Page

i.e. Scenario
0. Open dev tools.

1. Enter for sell token - 0.1
2. Put the cursor in front of the 1.
3. Start putting 0's.
4. Observe how many times Calculating gas cost is called.

Every time we change a digit ( remove / add ) gas calculation is triggered.

Implement a debounce function for the input.

Changes:

• Adding Navigation for the Tax Exporter and Exchange

Measurements: od-landing-v2.zip

I'm working on a market making bot for OasisDex, I notice that when placing an order via oasisdex, there is a fifth parameter (uint256 pos)?

It seems it's not required as orders are accepted without it but I assume it serves a purpose? Do I need it or can it be safely ignored?

Please put in the comments below whatever you think needs to find it's way into the TechDoco Wiki

I have updated the recent oasis.direct design mockup with the help of the team feedback:

changes:

• legal agreement information box with checkbox added
• replaced order information from the bottom to the top
• added token description to the picker
• changed the price to show the base/quote currency
• renamed "fee" to simple "gas cost"
• changed the widget size to 470 w 420 h

Tested only on KOVAN so far

0. Create new (fresh) account
   1 Get some MKR token ( https://oasisdex.com)
1. Go to oasis.direct
2. Select MKR -> ETH trading pair
3. Gas calculation throws an error in the dev console and the Gas cost loading spinner keeps on spinning. (error: Uncaught (in promise) Error: Error: Transaction execution error. )

Tried with DAI and it worked fine.

Currently: DEPOSIT & RECEIVE Inputfield shows numbers with 18 decimals
Should be: DEPOSIT & RECEIVE Inputfield shows numbers with 5 decimals

Requirements:

• Oasis should be the default Exchange
• Etherdelta and 0x are disabled until we are adding the functionality
• After the user clicked on the button Create Report, it is not possible for him to start the process again while the exporter is in process.

Export all past trades since fromBlock:5172142 into csv file so that @luke7211 can create a nice summary of current traffic coming from Oasis Direct

current:

should:

bg: #448AFF
border: #3E7BE6

Measurements: faq-measurements.zip

When user is idle for a long time, the market may have moved substantially increasing the risk that the threshold of 1% (or whatever) will not be met. It will be useful if the price was automatically updated every 60 seconds

Currently: just plain text

Should be: hyperlink to etherscan for specific transaction

Currently:

should look like:

Changes:

• Change Price to Approx. Price
• Add Price Slippage
• Reposition the Gas Price and change from ETH to USD value.
• Add the balance for each Asset Picker
• Added advanced Settings Button
• Insufficent funds warning message will now be shown beneath the order informations. With that people can now check prices without having actually the balance on their wallet.

Measurements:od-settings.zip
Settings Icon:

currently:

should be filled like MKR:

While testing oasis.direct on the mobile ethereum client cypher I am realising that it doesn`t make sense to give the user the possibility to exchange 0,0001 DAI. We need to define a min value for each token which is traded on oasis.direct.

For the first release we are going to have tokens with min value:

• ETH 0,03 ETH
• MKR 0,03 MKR
• DAI 30 DAI

Oasis Direct widget (without TAX export ) should be done in a way that 3rd party providers can inject it into their web application and use it as a standalone widget.

Proper documentation should be create as well.

1. Enter some amount in the pay token input field
2. Use one of the token pickers to select a token
3. The token picker is opened but instead of selecting a new token, just close the picker
4. The input fields are cleared.

Expected behavior: The input fields shouldn't be cleared if no token was selected

Export Trades seems to be making XHR requests to https://oasisdex.github.io/oasis-dex-script/maker-otc-*.trades.json which fail when uBlock is active. This causes the UI to replace the Generate Report button with a spinner which never expires.

When you trade MKR-ETH and type 0.03 in the ETH box the MKR amount is below 0.03. Transaction will fail but with a very misleading error messagage leading user to believe that 1% threshold has been broken. This is repeatable.

Measurements: oasis-direct-landing-mobile.zip

Price: 1.3 MKR/ETH instead of just 1.3 ETH

changes:

• the whole box should not be clickable anymore
• if you click on Terms and Condition a new tab should open up (link will coming soon)
• Terms and Condition should have the color #448AFF

Migrate the landing page from the oasis-direct application to the base one.
Integrate the widget in there

Hey guys,

I want to define the requirements/task for the next version of oasis.direct. The whole requirement plan is not written in stone so I would like to have more input from the whole oasis team. All those changes will be worked on after we moved the base project to a redux/react version which @peculiarity is started to work on.

oasis.direct widget requirements:

• Including an interface/page to let the user set their own gas price and threshold limit (via exact price or percentage limit)
• Native mobile widget implementation
• Implementing an automatic way of dealing with the threshold for specific pairs. If the Ethereum network is clogged (which means it is harder to do market making), we should increase the threshold.

oasis.direct website requirement:

• adding two new dashboard like widgets which are showing DAI markets and a 24 Hour Statistic of the oasis contract.
• add an interace which shows the wallet address of the user
• add an interface where the user can lookup their balances of each token asset.
• add an indicator for connectivity.
• add a transfer page

This is a feature suggestion on top of #50

It would be fantastic if at the end of conversion process the widget did javascript code of window.postMessage({type: 'oasis-direct.conversionCompleted', ...}, '*'). This would allow the nesting party to trigger it's own logic after conversion and integrate oasis.direct widget more smoothly.