Giter Club home page Giter Club logo

chchpd's People

Contributors

m-macaskill avatar rezashr avatar zenourn avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

Forkers

rezashr

chchpd's Issues

Flag for screening sessions

Currently the 2015 screening sessions (study == "Screening PD") are treated as normal sessions, but this gives two unexpected results:

  • Only ≈5 cognitive tests are performed, but this is still flagged as full_assessment == TRUE.
  • For these subjects, global_z_baseline is therefore based on this small set of tests (rather than on the full session which typically happens shortly after). This is not necessarily a problem, though it might be useful to have a per session metric e.g. global_z_total_tests to make it more explicit that this might be different to other cohorts.

Authenticate issue

Recently, I've noticed an error during the authentication process: "Sign in with Google temporarily disabled for this app, This app has not been verified yet by Google in order to use Google Sign In."

Currently, the way around it is to create a project in the google cloud, enable drive and spreadsheet APIs, and then create a OAuth2.0 for it. The client_id and secret can be used in googlesheet::gs_auth() to proceed with the authentication.

Error with import_medications ()

When running import_medications I get an error:

medications = import_medications()
Error: Assigned data `0` must be compatible with existing data.
Error occurred for column `other_medications`.
x No common type for `value` <double> and `x` <character>.

I assume this is likely a data problem. There are now sheets 'PD Progression Clinical Data' and 'NEW PD Progression Clinical Data'. Has this function been updated to use NEW? Are there any changes that would of caused this?

Getting ready for the new version of Googlesheets4

As of version 0.2.0 of googlesheets4, most of the functions are renamed and the old ones are deprecated. The initial convention was sheets_* for function names, but it is changing to gs4_* for most functions. For instance, sheets_auth() will be changed to gs4_auth() and so on. One exception would be range_read() to replace sheets_read().

Perhaps it would be ideal to start a new branch ready for the new version of gs4.

Update to use new export file from REDCap

The REDCap NP summary export file is being moved to a new location and name to better reflect it's source and content. The data will still be exported to the current location concurrently for a month, but chchpd should be updated to use this new location:

NZBRI PD Progression Study\Data and analysis\Data - redcap\NP_Summary_Export_raw.gsheet

There are also three new fields that have been added to the new file:

  • redcap_record_id
  • redcap_repeat_instance
  • redcap_session

When redcap_fields = TRUE is passed to import_neuropsyc() then these three fields should be included in the returned data.

This change in the export is discussed further at https://github.com/nzbri/redcap/issues/52

Upgrade deprecated functions for Googlesheets and Googledrive packages

Googlesheetsand Googledrive packages have been updated to use the input argument client instead of app. This causes login issues when packages are updated.

library('chchpd')

Data import functions for the Christchurch Longitudinal Parkinson's Study. Should be run only by accredited researchers at NZBRI, who have authorised access to the data sources.
Warning messages:
1: The app argument of gs4_auth_configure() is deprecated as of googlesheets4
1.1.0.
Please use the client argument instead.
The deprecated feature was likely used in the chchpd package.
Please report the issue to the authors.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was
generated.
2: The app argument of drive_auth_configure() is deprecated as of googledrive
2.1.0.
Please use the client argument instead.
The deprecated feature was likely used in the chchpd package.
Please report the issue to the authors.

Include global_z_historical in np export

In response to https://github.com/nzbri/redcap/issues/53, need to return two global_z values. The default global_z will now be the mean of all five domain means. So also need to return the new, additional global_z_historical variable, which excludes the language domain in case people wish to be compatible with earlier analyses.

Also need to export the newly-added neuropsyc exclusion variable.

Make chchpd robust to addition of new columns in source spreadsheets

There are now several new columns that I need to add to the redcap exports. However, with the current design of chchpd requiring an exact number of columns in source files, this is extremely difficult to deploy as need to simultaneously:

  • Update source file to have additional columns
  • Update chchpd column specifications to use these new columns
  • Update every installed copy of chchpd (as existing installations will break with addition of new columns).

I'm proposing that chchpd should ideally have an implementation such that it ignores any additional columns in source data files rather than this causing an error. This will make development much easier as can then update chchpd and deploy progressively and will also resolve issues that have occurred when users have inadvertently added new columns to spreadsheets.

Is there any reason for not making this change? Is the current implementation for technical reasons only?

When using on server - Access blocked: This app’s request is invalid

I've now got two cases where the new version of chchpd is giving an access blocked error when using RStudio on the server (Kyla on the NZBRI server and my account on my home server). However, for my account on the NZBRI server it is working fine and also trying in a fresh account it worked as well. My current hypothesis is that there is something cached that is causing a problem but I haven't been able to find it yet. Error details below.

Access blocked: This app’s request is invalid: [email protected]

You can’t sign in because this app sent an invalid request. You can try again later, or contact the developer about this issue. Learn more about this error
If you are a developer of this app:

Error 400: redirect_uri_mismatch

The redirect URI in the request, urn:ietf:wg:oauth:2.0:oob, can only be used by a Client ID for native application. It is not allowed for the WEB client type. You can create a Client ID for native application at https://console.developers.google.com/apis/credentials/oauthclient

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.