In NYTPhotosViewController.m, this line:

activityViewController.completionHandler = ^(NSString *activityType, BOOL completed) {

throws this warning:

'completionHandler' is deprecated: first deprecated in iOS 8.0 - Use completionWithItemsHandler instead.

Because of this, from UIActivityViewController.h:

@property(nonatomic,copy) UIActivityViewControllerCompletionHandler completionHandler NS_DEPRECATED_IOS(6_0, 8_0, "Use completionWithItemsHandler instead.");  // set to nil after call
@property(nonatomic,copy) UIActivityViewControllerCompletionWithItemsHandler completionWithItemsHandler NS_AVAILABLE_IOS(8_0); // set to nil after call

People should know what they're getting themselves into.

There seems to be a problem with the way this library loads images from its resources bundle.

From the looks of it you guys are using [UIImage imageNamed:] in NYTPhotosViewController, which searches the main bundle. On my device, that doesn't work, and the image is not loaded. I'm not very familiar with the way Cocoapods works, but it may have something to do with the fact that I'm using use_frameworks! in my podfile.

I think the easiest way to fix this is to use [UIImage imageNamed:inBundle:compatibleWithTraitCollection:] with the bundle received from [NSBundle bundleForClass:], as that will load the image from the appropriate bundle.

Just as a side note, I see you guys are using resources and not resource_bundles in your podspec, and I think the cocoapods team has deprecated resources in favor of resource_bundles.

Thanks in advance for replies 👍

This is the default behavior when presenting view controllers that don't show the status bar, however we could account for it in the animator.

Thanks for cool control!
We need url photo downloading and catching support

If you use initWithPhotos:initialPhoto the initial photo does not have pinch zoom or double tap zoom capabilities. I believe this is because no delegate is set when (NYTPhotoViewController *)newPhotoViewControllerForPhoto:(id <NYTPhoto>)photo is invoked.

Work around is to just use initWithPhotos and then set the delegate before displayPhoto:

NYTPhotosViewController *photosViewController = [[NYTPhotosViewController alloc] initWithPhotos:self.slideShowPhotosArray];
photosViewController.delegate = self;
[photosViewController displayPhoto:[self.slideShowPhotosArray objectAtIndex:index] animated:NO];

NYTPhotosViewControllerDelegate’s photosViewController:didDisplayPhoto:atIndex: is not called for the initial photo.

Noticed when testing this morning, particularly when the crop in the slideshow is "portrait" and the reference view is "landscape", the transition animation "pops" in an odd way. To recreate, look at the Photos section of newsreader this morning (3/17/2014), open the slideshow "Honnold's Upward Climb", and dismiss the first photo.

Steps to Reproduce

1. Run either of the sample projects.
2. Tap the photo.

Expected Results

An “X” button called NYTPhotoViewerCloseButtonX is displayed in the upper left corner of the view controller.

Actual Results

No “X” button is displayed and the nyt_photoViewerResourceBundle method returns nil.

Platform and OS

Tested both Swift 2 (with minor changes to get it to compile) and Objective-C sample projects as well as another project.

Xcode Version 7.2 (7C68)

Instead of just modal. Maybe.

Hi,

I am trying to call updateImagesOnPhotosViewController but the first time I load the NYTPhotosViewController VC the images don't load (although the spinner rotates) apart from the one marked in "initialPhoto". If I enter the VC the second time all images are loaded successfully.

Any ideas?

- (void)bigButtonTapped:(NSUInteger)index {

    NSMutableArray *photos = [[NSMutableArray alloc] initWithCapacity:_images.count];
    for(int i=0; i < _images.count; i++) {
        NYTExamplePhoto *tempImage = [[NYTExamplePhoto alloc] init];
        tempImage.image = nil;
        [photos addObject:tempImage];
    }


    NYTPhotosViewController *photosViewController = [[NYTPhotosViewController alloc] initWithPhotos:photos initialPhoto:[photos objectAtIndex:index]];
    photosViewController.leftBarButtonItem.tintColor = [UIColor whiteColor];
    [self presentViewController:photosViewController animated:YES completion:nil];
    photosViewController.delegate = self;

    [self updateImagesOnPhotosViewController:photosViewController afterDelayWithPhotos:photos];


}

// This method simulates previously blank photos loading their images after some time.
- (void)updateImagesOnPhotosViewController:(NYTPhotosViewController *)photosViewController afterDelayWithPhotos:(NSArray *)photos {
    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
        for (NYTExamplePhoto *photo in photos) {
            if (!photo.image) {
                NSString *photoUrl = [_images objectAtIndex:[photos indexOfObject:photo]];
                UIImageView *imageView = [[UIImageView alloc] init];
                [imageView setImageWithURL:[NSURL URLWithString:photoUrl] usingActivityIndicatorStyle:UIActivityIndicatorViewStyleWhite];

                photo.image = imageView.image;

                [photosViewController updateImageForPhoto:photo];
            }
        }
    });
}

On iPhone 5 (at least), when testing with the example project photo, fully zooming in (portrait) takes 3 sets of double taps instead of 2 which I believe was the intention (and is the case in my iPhone 6 Plus testing).

Zoom to 100% on all devices on double tap.

That way the tests will be run continuously.

When application has custom UINavigationBar appearance NYTPhotoViewer do not ignore it.

I pass along an image array like this

#import <NYTPhotosViewController.h>
....
-(void)myfunction{
  NYTPhotosViewController *mySlideShow = [[NYTPhotosViewController alloc]initWithPhotos:self.myImageArray];

 [self presentViewController:mySlideShow animated:YES completion:nil];
}

and now when I run the app and click on the image to present the viewcontroller I get an exception error for an unrecognized selector sent to instance

2015-03-30 12:39:39.491 *my app*[2822:51678] -[UIImage image]: unrecognized selector sent to instance 0x7f9143c8f000
2015-03-30 12:39:39.526 *my app*[2822:51678] *** Terminating app due to uncaught exception     'NSInvalidArgumentException', reason: '-[UIImage image]: unrecognized selector sent to instance 0x7f9143c8f000'
*** First throw call stack:
(
    0   CoreFoundation                      0x000000010afc7a75 __exceptionPreprocess + 165
    1   libobjc.A.dylib                     0x000000010ac60bb7 objc_exception_throw + 45
    2   CoreFoundation                      0x000000010afced1d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
    3   CoreFoundation                      0x000000010af269dc ___forwarding___ + 988
    4   CoreFoundation                      0x000000010af26578 _CF_forwarding_prep_0 + 120
    5   *my app*                          0x0000000108e166e6 -[NYTPhotoViewController initWithPhoto:loadingView:notificationCenter:] + 246
    6   *my app*                          0x0000000108e1d167 -[NYTPhotosViewController newPhotoViewControllerForPhoto:] + 343
    7   *my app*                          0x0000000108e1aaca -[NYTPhotosViewController setupPageViewControllerWithInitialPhoto:] + 602
    8   *my app*                          0x0000000108e1a785 -[NYTPhotosViewController initWithPhotos:initialPhoto:] + 1589
    9   *my app*                          0x0000000108e1a0f0 -[NYTPhotosViewController initWithPhotos:] + 128
    10  *my app*                         0x0000000108dfec37 -[GSItemDetailViewController NYTImageController] + 135
    11  UIKit                               0x0000000109645a22 -[UIApplication sendAction:to:from:forEvent:] + 75
    12  UIKit                               0x000000010974ce50 -[UIControl _sendActionsForEvents:withEvent:] + 467
    13  UIKit                               0x000000010974c21f -[UIControl touchesEnded:withEvent:] + 522
    14  UIKit                               0x00000001099f3e80 _UIGestureRecognizerUpdate + 9487
    15  UIKit                               0x000000010968b856 -[UIWindow _sendGesturesForEvent:] + 1041
    16  UIKit                               0x000000010968c483 -[UIWindow sendEvent:] + 667
    17  UIKit                               0x0000000109658fb1 -[UIApplication sendEvent:] + 246
    18  UIKit                               0x0000000109666227 _UIApplicationHandleEventFromQueueEvent + 17700
    19  UIKit                               0x000000010964123c _UIApplicationHandleEventQueue + 2066
    20  CoreFoundation                      0x000000010aefcc91 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
    21  CoreFoundation                      0x000000010aef2b5d __CFRunLoopDoSources0 + 269
    22  CoreFoundation                      0x000000010aef2194 __CFRunLoopRun + 868
    23  CoreFoundation                      0x000000010aef1bc6 CFRunLoopRunSpecific + 470
    24  GraphicsServices                    0x000000010cf8fa58 GSEventRunModal + 161
    25  UIKit                               0x0000000109644580 UIApplicationMain + 1282
    26  *my app*                          0x0000000108df7673 main + 115
    27  libdyld.dylib                       0x000000010c4e2145 start + 1
   28  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

2015-03-03 16:26:34.950 NYTPhotoViewer[7582:613] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Auto Layout still required after executing -layoutSubviews. NYTPhotosOverlayView's implementation of -layoutSubviews needs to call super.'

We are calling super in that layoutSubviews.

(title was: "Initial photo doesn't support custom loading view or maximum zoom scale")

on develop, delegate calls looking for a loading view and for a customized maximum zoom scale won't be made for the initial photo.

This has to do with the delegate not being assigned until after the initializer completes; as part of that process the PhotosViewController tries, and fails, to ask the delegate for this information. Fixing will require setting a delegate in the initializer, or deferring some amount of setup until after initialization.

Additional links & discussion

• #91 (comment)
• #110
• #119

For instance, I have 10 images. When I click on the the third image I would like the photo viewer to open at 3/10 so that I could then swipe back to get to 2,1. Sorry if this is the wrong place to ask.

Thanks!

The default implementation for sharing a photo (in NYTPhotosViewController - actionButtonTapped), doesn’t work with Facebook & Twitter. The image is not shown in the share dialog and the "post" button remains disabled.

This is because the activity items passed to UIActivityViewController’s constructor (https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIActivityViewController_Class/#//apple_ref/occ/instm/UIActivityViewController/initWithActivityItems:applicationActivities:) must adopt UIActivityItemSource protocol. Currently a UIImage instance is passed as an activity item. UIImage does not adopt this protocol.

The share action can be handled manually ( by implementing photosViewController:handleActionButtonTappedForPhoto: ), but still the default implementation should also work.

The following gif demonstrates what happens when you try to keep a reference to the photos VC around:

This was on @mpkeefe's Swift example branch before he resolved it via aa27285 .

This hints to me that something doesn't get reset properly after the VC is dismissed, and the VC is in a bad state if you try to present it again.

Holding on to and reusing a view controller is perfectly reasonable, even if most of the time a VC is presented only once.

NYTPhotosViewController inherits the supported interface orientations from the presenter, because the modal presentation style is set to UIModalPresentationStyleCustom.

My presenter view controller only supports portrait mode, but I would like to support landscape on the NYTPhotosViewController.

I have set NYTPhotosViewController's presentation style to the default value (UIModalPresentationStyleFullscreen) after the initialization to support other orientations too, but this breaks at least the interactive fade animations when UIPhotosViewController is closed by swiping the view up or down.

It would be great if we could make the dismiss function public to that the viewcontroller can be removed through custom logic. An option would be to access the done button method.

- (void)doneButtonTapped:(id)sender {
    self.transitionController.forcesNonInteractiveDismissal = YES;
    [self setOverlayViewHidden:YES animated:NO];
    [self dismissAnimated:YES];
}

Because iOS 7 transition APIs really didn't like landscape.

I am using the latest version of NYT and everything is working absolutely fine except the close button is hidden since I switched to cocoapods use_frameworks. Does anyone have any idea how to solve this issue?

Thanks :)

EDIT: Seems to be related to this issue: #64
I'm using cocoapods and use_frameworks as well.

Hi,

thank you for this great library, the API is so well designed and documented, that integrating it in our application was a pleasure :)!

We've noticed a tiny flickering when you run an app that only supports iPhone on an iPad.

Steps to reproduce the bug:

• Change Deployment Info -> Devices from Universal to iPhone
• Run the example project on an iPad (or iPad Simulator)
• Tap on the photo
• You'll notice a flickering while the animation is running

Cheers,
plu

Possibly for caption view, overlay view, and even background color on the view controllers.

Locally I have subclassed this AWESOME NYTPhotosViewController and overridden the method "updateOverlayInformation". But I could do a PR so we could localize this in different languages?

Again, hell of a job you have done here. With my two hands, three thumbs up 👍 👍 👍

Related:

Are you planning to add animated GIF support?

If not: Would you potentially be interested in having this in? For us this is definitely a requirement and I'd be keen to implement this and create a PR.

Cheers,
Marcus

How can i fix it?

And thank you for great control!

This issue is present on the master branch.
When the NYTPhotosViewController is presented from a formsheet viewcontroller, the size and the orientation are wrong.
As you can see from the screenshot, the final size is the size of the presenting viewcontroller. And if the NYTPhotosViewController in landscape the orientation is still portrait.

I created a sample project to demonstrate the issue here: https://github.com/ignazioc/NYTPhotoViewer/tree/ios7_testing

This is not a bug sorry for creating an issue
How can I avoid the black space while tapping at the corner ?
Kindly help me on this. Thanks in advance

For example, if you present in landscape and then rotate to portrait, the navbar will still be small.

Is it possible to create a UIScrollView instead of UILabel in photo captions ?

When captions are too long it seems ugly in screen.

Instead of UILabel I think it will be good to create that label in scrollview like facebook does.

If the label has more than our pre defined lines (for example 5 lines) it will be converted to scrollview.

Terminating app due to uncaught exception 'NSGenericException', reason: 'UIPopoverPresentationController (<_UIAlertControllerActionSheetRegularPresentationController: 0x7c48a5c0>) should have a non-nil sourceView or barButtonItem set before the presentation occurs.'

I agree.This was a beautifully designed library.But,would u mind creating this project for Swift User in Swift code?Because I don't know Obj-C code.I want to learn your library which was exactly in pinch and zoom feature and gesture function.

So,Thanks for your hard work!!!
Any help with Swift Version,Thank you,Sir.

As mentioned in #102.

Steps to Reproduce

1. Clone the project.
2. Attempt to run the Swift sample application target.

Expected Results

The app runs.

Actual Results

The app fails to build with a number of errors.

Platform and OS

Xcode Version 7.2 (7C68)

On my iPhone 6 Plus while testing in newsreader, I've intermittently seen the text below the photo in a slideshow appear glitchy (jumping from being aligned at the bottom to above that position quickly back and forth) when swiping between the first and second photo. It's inconsistent, and not definitive, but I've only seen this happen after scrolling the article before tapping the slideshow.

Would be awesome to have Carthage support.

+// Copyright (c) 2015 Brian Capps. All rights reserved.

to

+// Copyright (c) 2015 NYTimes. All rights reserved.

can you plz make the ability to asyncro. load the images and show a progress bar while loading the image

If viewcontroller that present NYTPhotosViewController not support Landscape orientation NYTPhotosViewController not support it too.
But what if i want rotate photo?

When you have a controller on screen with a set of photos and then call displayPhoto:, overlay info should be updated to display correct photo number.

This is my first GitHub issue, so maybe it is also a time for my firts one-liner PR?

It seems like the orientations supported when presented matches the set orientations on the presenting view. Is there a way, or could you add a way, so that the photos viewer can be rotated even if the presenting view can't?

On 6 Plus, zooming in via 2 finger gesture or double tap, and then zooming out (either way) prevents the ability to swipe horizontally to another photo or vertically to dismiss. This doesn't occur every time, but is very easily reproducible on device.

When swiping between photos, the captions don't change until the transition from one photo to another completes. Though not as straight forward from a coding perspective, it'd be nice if the information would update halfway through the transition so that the captions always apply to the photo that is occupying most of the screen.

I made a sample app (PRs: #25 #27) in Swift that mimics the current example ObjC app and runs on both iPhone and iPad, using the built-in NYTPhotosViewController. On iPad, the ShareActivityViewController crashes because it needs to be presented inside a popover. This can be done in iOS 8 simply by setting shareActivityViewController.popoverPresentationController?.barButtonItem but on iOS 7 will need to wrap inside a UIPopoverController I guess. Are there any other considerations?

Looks like a problem with the asset catalog.

Console:
2015-03-30 22:14:42.422 NYTPhotoViewer[17453:607] Unable to create unsliced image from csi bitmap data.
2015-03-30 22:14:42.438 NYTPhotoViewer[17453:607] Could not load the "NYTimesBuilding" image referenced from a nib in the bundle with identifier "org.cocoapods.demo.NYTPhotoViewer"

Found this

It's unexpected that the following doesn't work:

#import <NYTPhotoViewer/NYTPhotoViewer.h>

It would be great if there was an umbrella header. This will be required for #61 anyway :)