Tbh, this is a really cool project I love the design and idea, simple but useful. I was wondering, what if there's the same quote with the other contributors. Is that okay or acceptable?

I got this bug when open quote page

I was thinking about to bring search feature
Here are my poor design

There are also a search filter just like github issue search bar (maybe)
We can filter it by

• Quote (text)
• From (author)
• User (github user)

What do u think?

I think, my bug in the previous search feature still there.

When i want to search for quotes "dan", and i scroll it to the bottom until infinite scroll finish load the quotes. Then i want to reset my search, but when i scroll it to bottom, the infinite scroll didn't load the new quotes.

Maybe the problem is the scroll listener on window has been removed if we already load all quotes.

For now we are consuming the github avatar provided by github directly. The truth is that github provides an avatar image of about 420x420 in size with the byte size being around 29Kb-30Kb. This makes our website load heavily by thinking about the number of github avatars that are loaded, even though we have implemented lazy loading on images but if there is still a way to optimize it, why not?

So github has an additional parameter in its avatar url, namely s= which has a positive integer value that represents the width of the image. We can use this method to reduce the image size, because we only need 24x24 size so we can add s=24 behind our github avatar url in <QuoteCard /> component. We can reduce byte size of image up to ~94%. Such drastically different right?.

I working on it, so i'm ganno ship this update soon.

I'm just wondering why not search both by username or name?

Currently if there is a github account then search by github name, if not then search by username written in the quote

this is why i've do pull request with name Adding Like Quote and save it to localstorage

• Forgetting Save quote and forget keyword to searching quote
• Saving quote to storage device but not need to share in social media
• Simple saving quote without spamming on device storage,
• simple feature with filtering which Quotes we like or no, we just click toggle button and all quotes are showing

halo mas @nyancodeid sekarang aku lg belajar web programming aku iseng buat app ini wallofresolution inspirasinya dari app quote mas @nyancodeid dan aku mau izin pake palet gradienttnya punya mas karena blm bisa buat pallet gitu hehe. Terimakasih sebelumnya

I think something went wrong!

*I haven't checked the source code yet!

When we click the download button, it will make the dialog card scaling down and back to normal. Is this deliberate?

Having a light/dark theme option for the UI can be a good addition.

this is my good first time issue for hacktoberfest 2022! please support :)

It is about the reactivity of the search feature, I think when we change the search category (dropdown), it must be updating the result corresponding to the current category & keyword (no need to trigger any change in the keyword).

Here is for the detail.

Just trying to download the quote image, but it showed as a blurred image!

Please look at this:

I thought when quotes get longer the other element goes weird. it looks like we have blank block here.

what about to make their height same with each other. I mean we hide long quote's by previewing them, then make it visible when we hover on it. like how facebook does for their status profile. and yes add animation on it so the page will still look live.

to make it looks live, I add hoverable element on quotes card.

it will look like this

uhh I'm staring at it ✨

Hi there 👋, because my domain nyandev.id will expire in the end of January 2022 and because I can't renew the domain so I decided to change the domain from the all web I created to *.nyan.my.id.

Thank you for using this web application.

Just because search or filter feature was added, I think we need to handle when the result is empty. Like using an empty state design. It is useful to tell the user that no result found with a nice way.

I realize that we doing so many deployment using Cloudflare Pages. But Cloudflare Pages has limited deployments (500 every month). And, we don't actually have build preview for every PR, sometimes it's annoying when we need to review features that need to reviewed both design and code.

So, i think we need move into Vercel. I believe Vercel already have all we need.

I think we must have a different empty message for favorite quote. The current empty message unrelated with the favorite feature, and currently we don't search anything.

For example:

Anda belum memiliki quote favorit, …

We have ± 81 yaml files inside of quotes folder, and it's mean everytime we run npm run generate:quotes we have to fetch 81 times to Github API to get users detail like full a name, avatar, and follower count. Couple days ago i create a PR #60 that include an optional Github Token as a Environment Variable helped by .env / .env.local files. Why i did this? because Github API is rate limited without Authentication or Token.

Now that the rate limited problem has been solved by using tokens, now many requests make it slow. And I just realized, why don't we call it using GraphQL instead. Some may ask what is the difference between GraphQL and the REST API used today.

Well , with GraphQL, it is very possible for us to retrieve more than one user data in one request. So we can simply determine how and what data we will receive by sending a formatted query according to what is provided by Github GraphQL. So instead of sending 81 requests to the Github API we can easily get them with 1 request using Github GraphQL.

I am working on it, so stay tune.

Reference

• https://docs.github.com/en/graphql/guides/introduction-to-graphql

What should be the behavior for this cases?

Case 1
When we do a search on all quotes (not favorites), then switch favorite quotes, then switch back to all quotes, it will show all quotes instead of filtered quotes even search keyword exists

Case 2
When we do a search on all quotes, then switch favorite quotes, it will show all favorite quotes instead of filtered favorite quotes even search keyword exists

I think it would be better to add some effects when hovering over the quote filter

Great project ! Simple but elegant ! @nyancodeid

I wonder whether we could add new author's description and show it on the card ? So everybody who reads the quotes also knows who/what is the author's job (CEO of xxx, Founder of xxx, etc.) ?