nwn-dotnet / nwn.masterlist Goto Github PK

public async static Task<IOrderedEnumerable<NwServer>> GetAllNwSyncManifestHash(this Client client)
{
    return ((IOrderedEnumerable<NwServer>)(await client.GetServers()).Select(x => x.NwSync.Manifests.Where(y => y.Hash != string.Empty))).OrderBy(x => x.ModuleName);
}

[Fact]
public async void TestGetAllNwSyncManifestHash()
{
    var collection = await new MasterList.Client().GetAllNwSyncManifestHash();
  
    foreach (var item in collection)
    {
        //output.WriteLine($"{item.ModuleName} -> {item.NwSync.Manifests}");
    }
  
    Assert.NotEmpty(collection);
    Assert.NotNull(collection);
}

NWN.MasterList.Test.Client.TestGetAllNwSyncManifestHash:
Outcome: Failed
Error Message:
System.InvalidCastException : Unable to cast object of type 'SelectListIterator2[NWN.MasterList.Data.NwServer,System.Collections.Generic.IEnumerable1[NWN.MasterList.Data.Manifest]]' to type 'System.Linq.IOrderedEnumerable`1[NWN.MasterList.Data.NwServer]'.
Stack Trace:
at NWN.MasterList.Helper.GetAllNwSyncManifestHash(Client client) in c:\Users\scott\Desktop\NWN.MasterList-1\API\src\Helper.cs:line 115
at NWN.MasterList.Test.Client.TestGetAllNwSyncManifestHash() in c:\Users\scott\Desktop\NWN.MasterList-1\Test\src\Client.Test.cs:line 397
at System.Threading.Tasks.Task.<>c.b__140_0(Object state)

Total tests: 1. Passed: 0. Failed: 1. Skipped: 0

Enforce uniform formatting of code when pushed up via PR, etc. Allow code format to be what the user wants at a local level.

https://github.com/milliorn/NWN.MasterList-1/blob/e2f1b4018009e2f9a5939d8d0ed9c7b0e4f21b3a/API/src/PrintJson.cs#L12-L12

https://github.com/milliorn/NWN.MasterList-1/blob/7d26f308ecbf2a34e06535f9a9a85c7c6e88bd0c/API/src/Helper.cs#L28-L28

Future enhancement.

https://github.com/milliorn/NWN.MasterList-1/blob/214a37ab8ebf04fd891da46ab8f082304c3f47ec/API/src/Helper.cs#L37-L37

NWN.MasterList.Test.Client.TestGetAllElcByType:
Outcome: Failed
Error Message:
System.InvalidCastException : Unable to cast object of type 'SelectIPartitionIterator2[NWN.MasterList.Data.NwServer,System.Boolean]' to type 'System.Linq.IOrderedEnumerable1[NWN.MasterList.Data.NwServer]'.
Stack Trace:
at NWN.MasterList.Helper.GetAllElcByType(Client client, Boolean setting) in c:\Users\scott\Desktop\NWN.MasterList-1\API\src\Helper.cs:line 41
at NWN.MasterList.Test.Client.TestGetAllElcByType() in c:\Users\scott\Desktop\NWN.MasterList-1\Test\src\Client.Test.cs:line 97
at System.Threading.Tasks.Task.<>c.b__140_0(Object state)

public async static Task<IOrderedEnumerable<NwServer>> GetAllElc(this Client client) =>
	(await client.GetServers()).OrderBy(x => x.ELC).ThenBy(x => x.ModuleName);

  // TODO #17
public async static Task<IOrderedEnumerable<NwServer>> GetAllElcByType(this Client client, bool setting)
{
	var response = await client.GetAllElc();
	return (IOrderedEnumerable<NwServer>)response.Select(x => x.Equals(setting));
}

[Fact]
public async void TestGetAllElcByType()
{
    var collection = await new MasterList.Client().GetAllElcByType(false);

    foreach (var item in collection)
    {
        output.WriteLine($"{item.ModuleName} -> ELC:{item.ELC}");
    }

    Assert.NotEmpty(collection);
    Assert.NotNull(collection);
}

There is an issue with GetAllElcByType function and how I am casting (IOrderedEnumerable<NwServer> result in the return.