Comments (4)
fuuuu an user yesterday wanted to load hl groups when requested to load nvim faster. But then, telescope users reported that the get_highlight_name was causing errors because it's called asynchronously and suggested wrapping in vim.schedule.
I guess maybe we should just revert back to how it was before.
from nvim-web-devicons.
should be fixed, sorry for the inconvenience
from nvim-web-devicons.
Cool! Beyond the inconvenience, I do understand the point of making things snappier. If you're interested in reinstating the behavior, maybe we could work out an API that is async-aware? E.g. it could return none
or a default HL group (Normal?) if the function is called before the devicon HL group is defined.
And btw what was the issue for non-vim.schedule for telescope?
from nvim-web-devicons.
telescope uses get_highlight_name
in a lua callback, so when we moved the nvim_command
call inside of it, it broke because vim functions need to be wrapped in a schedule
call when used asynchronously.
This is not too important rn, async stuff should be treated with caution and maybe rethinking how to make it work would take more time. Breakage like this is not supposed to happen, maybe tests would be required at some point.
from nvim-web-devicons.
Related Issues (20)
- Some icons not show correctly HOT 2
- Incorrect NF symbol shown for Rust HOT 5
- Create a category for icons from desktop environments and window managers HOT 2
- Cannot override some icons by filename HOT 7
- TeX icon incorrect HOT 1
- [QUESTION]: how to add custom icon to laravel blade files HOT 4
- Invalid highlight name HOT 15
- change only icon color HOT 1
- W18 invalid character in a group name HOT 2
- Default icon is not working correctly HOT 12
- FR: differentiate `.d.ts` from `.ts` files (typescript) HOT 3
- Add known issue to README
- Custom icons not working on latest nvim nightly HOT 7
- Gulpfile and Gruntfile incorrect icon HOT 12
- Add issue template HOT 6
- Cannot override Lua icon color HOT 9
- Add gleam icon HOT 1
- Feature: Allow setup to be run multiple times
- set_icon not work HOT 3
- Cannot install nvim-web-devicons properly on Nvim 0.7.2 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nvim-web-devicons.