Giter Club home page Giter Club logo

Comments (12)

sethen avatar sethen commented on June 27, 2024

I solved some of my issue. Part of it was I had to set some things for the file tree explorer itself. However, the default icon isn't working for everything.

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

To confirm: does the default default icon show when you remove set_default_icon ?

from nvim-web-devicons.

sethen avatar sethen commented on June 27, 2024

To confirm: does the default default icon show when you remove set_default_icon ?

Not sure what you mean... if I delete the set_delete_icon function does the default icon show??

from nvim-web-devicons.

sethen avatar sethen commented on June 27, 2024

Here is also another thing I am seeing -- I would assume the default icon would take over here when the TelescopePrompt comes up but it doesn't... However, it does when the help buffer is open. Check the status bar on the bottom right.

No default icon:
Screenshot from 2024-04-24 19-39-35

Default icon:
Screenshot from 2024-04-24 19-42-28

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

Experimenting with your setup:

require("nvim-web-devicons").set_default_icon('D', '#6d8086', 65)
print(vim.inspect(require("nvim-web-devicons").get_default_icon()))
{
  color = "#6d8086",
  cterm_color = 65,
  icon = "D",
  name = "Default"
}
require("nvim-web-devicons").set_default_icon('X')
print(vim.inspect(require("nvim-web-devicons").get_default_icon()))
{
  icon = "X",
  name = "Default"
}

That is working as intended, presuming that icon in your screenshot is require("nvim-web-devicons")

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

To confirm: does the default default icon show when you remove set_default_icon ?

Not sure what you mean... if I delete the set_delete_icon function does the default icon show??

Yes.

However... that's not to say that nvim-tree, telescope or lualine will actually use it, they may use their own.

Experimenting with nvim-tree and :NvimWebDeviconsHiTest shows that the default icon is not shown or used. Investigating...

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

:NvimWebDeviconsHiTest not showing the default is unrelated. Fixed at #451

nvim-tree is not showing the default icon, contradicting help:

            *nvim-tree.renderer.icons.web_devicons.file.enable*
            Show icons on files.
            Overrides |nvim-tree.renderer.icons.glyphs.default|
              Type: `boolean`, Default: `true`

        *nvim-tree.renderer.icons.glyphs.default*
        Glyph for files.
        Overridden by |nvim-tree.renderer.icons.web_devicons| if available.
          Type: `string`, Default: `""`

Raised nvim-tree/nvim-tree.lua#2758

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

RE lualine: it does not show default icons. I'll leave telescope to you...

Does resolution of this issue resolve your concerns?
nvim-tree/nvim-tree.lua#2758 (comment)

from nvim-web-devicons.

sethen avatar sethen commented on June 27, 2024

RE lualine: it does not show default icons. I'll leave telescope to you...

Does resolution of this issue resolve your concerns? nvim-tree/nvim-tree.lua#2758 (comment)

I left a comment over there. Happy to test, just unsure how.

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

Fixed via nvim-tree nvim-tree/nvim-tree.lua#2759

from nvim-web-devicons.

sethen avatar sethen commented on June 27, 2024

@alex-courtis Still not seeing the default icon taking effect even after updating nvim-tree.

from nvim-web-devicons.

alex-courtis avatar alex-courtis commented on June 27, 2024

@alex-courtis Still not seeing the default icon taking effect even after updating nvim-tree.

That's no good; we'll get to the bottom of this. I reckon it's nvim-tree.

Please raise an nvim-tree bug report with your nvim-tree and nvim-webdevicons minimal configuration so that we may reproduce and fix.

from nvim-web-devicons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.