numberly / flask-graphite Goto Github PK

First of all, thanks for implementing such a great tool!

Actual result

Flask graphite (source) normalizes slashes / in endpoint paths by converting them to pipe character |. For example:

stats.users.localhost.flask-graphite.data|users.size

Although such metrics are supported by Carbon, you have to manually escape the metric name in order to render the graph: stats.users.localhost.flask-graphite.data\|users.size. Unfortunately, this is not done by Graphite web, and we end up with "No data" screen for the metrics corresponding to hierarchical endpoint paths.

Note that Pipe character is considered a special symbol by Graphite. So this behaviour may be intentional.

&target=asPercent(Server{1,2}.memory.used,Server{1,3}.memory.total,0)|exclude("MISSING")

Expected result

Flask-graphite should generate metric names supported by Graphite web.

Environment

Graphite – 1.1.5
Flask-graphite – 0.6.0

Following #1 and its quick fix, we can end up in a situation where we try to use app.graphite but it doesn't exist. We should handle this and try to connect as long as we don't have a proper client.

Especially on dd16834 💯

The following line now emits an ImportError when trying to use this library:

Earlier this year _rule_re was moved to rules.py and then refactored away: pallets/werkzeug@5a7c0de

Graphitesend isn't maintained anymore, we should rebase on @Shir0kamii fork, graphitesender.

@app.route('/person'): # measure total call and duration
some validation check
database call # measure total call and duration

i do some validation checks and then execute a database call. Is it also possible to have a tree that shows the pt and count of the database call

And be consistent with our other projects (stop using tox)