Hey, this looks pretty close to what I need, but I am not sure how it would deal with an immutable object, that is replaced for every change.

To give you an example: a (non-Ember) library is returning an immutable object, that drives the UI state. On every change of the application state, that library is asked to return a new object, which is then assigned to a tracked property, to update the UI. That even works without any "deep" tracking, just plain @tracked, as the whole object is replaced. But this causes all parts of the UI to rerender, even those where the actual value didn't change.

Some pseudo code to illustrate the example:

class GlobalStateService extends Service {
  @tracked globalState = { foo: 0, bar: 0};

  @action
  updateFoo() {
    // instead of mutating the foo property, we simulate the immutable behavior by assigned a new POJO
    this.globalState = { ...this.globalState, foo: this.globalState.foo + 1 };
  }
}

When I consume both globalState.foo and globalState.bar in a template, after calling updateFoo() both would re-render, as the whole globalState has been updated. But what I would like to see is that only the parts depending on globalState.foo re-render, but those depending on globalState.bar don't, as the actual value didn't change.

That's kinda the behavior of @dedupeTracked, but with deep tracking.

I assume that's not what ember-deep-tracked currently does, right? Do you think it would be feasible to support that?

There is an issue with accessing the ember-data store from an object if that object is being kept in a deep-tracked array. A minimal example to reproduce the behavior can be found here: https://github.com/LeopoldHock/ember-deep-tracked-test

The core issue

Say we have a custom object that can make use of service injection by having its owner set in the constructor method.

export default class Car {
    @service store;

    constructor(owner) {
        setOwner(this, owner);
    }
}

And after instantiation, that object will be put into a nested deep-tracked context.

// e.g. in a service
import { tracked } from 'ember-deep-tracked';
@tracked data = {
    cars = []
}
let car = new Car(this);
data.cars.push(car);

And at some point, that object attempts to access the injected store to find a record.

// in car.js
let someRecord = this.store.peekRecord("my-collection", "some-key");

someRecord will be null, while requesting the same record in a different contect (e.g. a service) will return the record.
The issue does not occur in a non-tracked context (e.g. by simply removing @Tracked).

util file is available only on < 3.0.0
https://github.com/tracked-tools/tracked-maps-and-sets/tree/v2.2.1/src/-private

is there a way to just replace a part of the model with a tracked proxy ?

Like if i have
a.b = { x: "xx", y: "yy" }
and do
a.b = tracked(a.b) to replace instance of the sub-object with a proxy?

Just making this issue to raise awareness for anybody searching.

Here is a PR with failing tests

#308

With native @Tracked you can defined your tracked properties with no default values.

@tracked foo;
@tracked bar;

Even though as objects ember won't track these, the user is used to write it this way. When you start to use this addon, without adding = {} you get the following error

vendor.js:172922 Uncaught (in promise) TypeError: initializer is not a function

desc.get = function get() {
      if (!value) {
        value = deepTracked(initializer());
      }

is where the error is.

I think if you're using this addon, and you're trying to track the properties of an object, perhaps it could default to empty object? Or fail with a warning instead.

Demo repo:

amk221/-ember-deep-tracked-include-issue@b31a087

Error output:

Uncaught TypeError: Cannot use 'in' operator to search for 'Symbol(TARGET)' in 2
    at unwrap (index.js:14:1060)
    at Array.map (<anonymous>)
    at Proxy.fn (index.js:11:474)
    at get hasFoo2 [as hasFoo2] (application.js:22:1)
    at getPossibleMandatoryProxyValue (index.js:1699:1)
    at _getProp (index.js:1723:1)
    at reference.js:175:1
    at reference.js:136:1
    at track (validator.js:635:1)
    at valueForRef (reference.js:135:1)
unwrap @ index.js:14
fn @ index.js:11
get hasFoo2 @ application.js:22
getPossibleMandatoryProxyValue @ index.js:1699
_getProp @ index.js:1723
(anonymous) @ reference.js:175
(anonymous) @ reference.js:136
track @ validator.js:635
valueForRef @ reference.js:135
(anonymous) @ runtime.js:3269
evaluate @ runtime.js:1052
evaluateSyscall @ runtime.js:4214
evaluateInner @ runtime.js:4185
evaluateOuter @ runtime.js:4178
next @ runtime.js:5009
_execute @ runtime.js:4996
execute @ runtime.js:4971
(anonymous) @ runtime.js:5054
runInTrackingTransaction @ validator.js:138
sync @ runtime.js:5054
(anonymous) @ index.js:4726
(anonymous) @ index.js:4695
(anonymous) @ index.js:4988
inTransaction @ runtime.js:4090
_renderRoots @ index.js:4970
_renderRootsTransaction @ index.js:5014
_renderRoot @ index.js:4959
_appendDefinition @ index.js:4884
appendOutletView @ index.js:4874
invoke @ backburner.js:284
flush @ backburner.js:197
flush @ backburner.js:360
_end @ backburner.js:801
end @ backburner.js:592
_run @ backburner.js:845
run @ backburner.js:627
run @ index.js:74
callback @ index.js:355

🚨 The automated release from the main branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the main branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two Factor Authentication for your account, set its level to "Authorization only" in your account settings. semantic-release cannot publish with the default "
Authorization and writes" level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: Cannot find preset's package (github>whitesource/merge-confidence:beta)

Hi! i noticed the proxy has the same issues as tracked-built-ins.

The fixed I prepared there, can also map here 1:1

tracked-tools/tracked-built-ins#112

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update devdependencies (major) (@commitlint/cli, @commitlint/config-conventional, @ember/test-helpers, @embroider/addon-dev, @embroider/test-setup, @nullvoxpopuli/eslint-configs, @rollup/plugin-babel, @tsconfig/ember, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, concurrently, ember-cached-decorator-polyfill, ember-cli, ember-cli-app-version, ember-cli-babel, ember-data, ember-page-title, ember-qunit, ember-resolver, ember-source, ember-template-lint, ember-try, ember-welcome-page, eslint, eslint-config-prettier, eslint-plugin-ember, eslint-plugin-prettier, eslint-plugin-qunit, eslint-plugin-simple-import-sort, prettier, qunit-dom, rollup, semantic-release, typescript)
• chore(deps): update github artifact actions to v4 (major) (actions/download-artifact, actions/upload-artifact)
• chore(deps): update node.js to v20
• chore(deps): update pnpm/action-setup action to v3
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency webpack to v5.76.0 [security]
• chore(deps): update yarn to v1.22.21
• chore(deps): update devdependencies (@babel/core, @babel/plugin-transform-typescript, @babel/preset-typescript, @commitlint/cli, @commitlint/config-conventional, @ember/optional-features, @tsconfig/ember, @types/ember__error, @types/ember__polyfills, @types/ember__string, @types/ember__template, @types/htmlbars-inline-precompile, @types/qunit, @types/rsvp, babel-eslint, concurrently, ember-cli, ember-cli-htmlbars, ember-cli-typescript, ember-data, ember-fetch, ember-source, ember-template-lint, eslint, npm-run-all, prettier, qunit, rollup, rollup-plugin-ts, semantic-release, typescript)
• chore(deps): update node.js to v16.20.2
• chore(deps): update pnpm/action-setup action to v2.4.0
• chore(deps): update wagoid/commitlint-github-action action to v5.4.5
• chore(deps): update actions/cache action to v4
• chore(deps): update actions/checkout action to v4
• chore(deps): update dependency npm to v10
• chore(deps): update volta-cli/action action to v4
• chore(deps): lock file maintenance
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository