nubank / clj-github-app Goto Github PK

Hey @dryewo, sad to see you aren't in Berlin any longer but hope all is well on your end.

Thanks for this library! At Nubank we use a fork of it with several tweaks (#2 and #1).

I'm starting to look at open-sourcing some of the tools that use clj-github-app and part of that would require us opening up our fork of clj-github-app.
Given that, the fact that we have a few solid use-cases, and the fact that there hasn't been follow-up on the tweaks I mentioned, I was wondering if you'd be interested in passing this over to me and a few others at Nubank to maintain (like @rfhayashi + @jpalharini)

To make client/request* work I needed to add cheshire to my project.clj. clj-http will not parse json unless you do that. I could make a pull request to do that, but wanted to know if you think it is best to add an instruction in the readme, add it as an actual dependency, or maybe I'm missing something. Since clj-github-app explicitly uses the json parsing, I'd be inclined to add it as an actual dependency.

By the way, thank you for the library :)