ntpeters / remoteadv Goto Github PK

If the server dies unexpectedly while there are still clients attached to it, they do not exit cleanly.

This is fixed for the slave, but I haven't found a good way of doing this for the master client yet though.
The issue with master is that since it has a menu and is awaiting user input via scanf, I haven't found an easy way for it to detect if the server connection is lost until a command is issued. Apparently when a socket connection is broken, a SIGPIPE signal is supposed to be issued, but I have had no luck in catching it so far. I'm not sure if this is due to me running this all locally rather than over then internet or not. Worth looking into more.

We should check for any deprecated functions in our code and update them to their current counterparts. I'd say there's no rush on this, but it is something that should be taken care of at some point.
For example: Using memset() rather than bzero(). Using getaddrinfo() rather than gethostbyname(). This sets errno appropriately and would remove the need to check herror.

Since we are going to be doing this over the internet, we need to convert to and from network byte order where appropriate.

I tried testing this by running the server on my EC2 instance, and running a slave client on Guardian and the master client on my laptop. The clients were unable to connect to the server, so I'm thinking this may be the issue. It may not be, and if the problem persists after this task is completed I'll post it as a bug to look into.

We need cooler name for this project. 'nuff said.

Not sure if we would want to bother with this. Forking is an older threading model for servers and pthreads would be a more modern way of approaching it. I figure if we have time and want to learn a little about pthreads, then go for it. Otherwise, don't bother. This would also be something that we could hold off on for awhile, like until we have most other things working.
I found a sample server written using pthreads here: http://kturley.com/simple-multi-threaded-web-server-written-in-c-using-pthreads/

Do we really still want to do this? Seems kind of pointless overall. Opinions?

Any other useful commands should be added to the master client. Its functionality is pretty basic right now.

Implement the backend for the commands that the slave can receive. (open, close, read, write, exec, etc...) Add any others that may be useful, but don't have skeletons already.
These probably won't be used as bare commands from the master client, and will rather be part of other actions that we add to the master later on.