nteract / enchannel-zmq-backend Goto Github PK
View Code? Open in Web Editor NEWZeroMQ backend implementation for enchannel
License: BSD 3-Clause "New" or "Revised" License
ZeroMQ backend implementation for enchannel
License: BSD 3-Clause "New" or "Revised" License
You deprecated createChannels completely, but it is the first thing mentioned in the docs in the README.
CoCalc directly uses enchannel-zmq-backend via createChannels, so this was a little bit confusing, and I've been reading all the source code to figure out how to rewrite our code not using createChannels. Doing so wasn't hard, and in fact my code is a lot better just using createMainChannel. That said, you might want to rewrite the docs to reflect this (good) change.
The RxJS team is stellar and has convinced me we should just switch on over to RxJS 5. @kenwheeler is going to switch composition to RxJS 5 too.
We'll need to update the enchannel spec while we're at it for any interface changes.
/cc @Blesh
Branch | Build failing π¨ |
---|---|
Dependency | uuid |
Current Version | 3.0.1 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
uuid is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you itβs very likely also breaking them.
I recommend you give this issue a very high priority. Iβm sure you can resolve this πͺ
The new version differs by 6 commits.
c50ac88
Update readme & package version (#198)
082a0b3
v5 support in CLI (#197)
1d56dc9
V5 support (#188)
f37f96a
(fix) Add .npmignore file to exclude test/ and other non-essential files from packing. (#183)
3b21880
Fix typo (#178)
d8e41bd
Simple typo fix (#165)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot π΄
enchannel-zmq-backend/__tests__/index.spec.ts
Lines 154 to 159 in b7d509f
TODO
comment in b7d509f. It's been assigned to @captainsafia because they committed the code.As mentioned in nteract/nteract#115, we should upgrade our RxJS 5 version.
The changelog for RxJS 5 lists a bunch of performance improvements as well as fixing Subject.create
's arguments (we ran into this and they fixed it after our feedback). It needs adaption in any place where Subject.create
is used (flip the args).
error ~/Documents/Github/nteract/applications/desktop/node_modules/zeromq: Command failed.
Exit code: 1
Command: node scripts/prebuild-install.js || (node scripts/preinstall.js && node-gyp rebuild)
Arguments:
Directory: ~/Documents/Github/nteract/applications/desktop/node_modules/zeromq
Output:
prebuild-install WARN install No prebuilt binaries found (target=18.4.0 runtime=node arch=arm64 libc= platform=darwin)
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | darwin | arm64
gyp info find Python using Python version 3.10.9 found at "/opt/homebrew/opt/[email protected]/bin/python3.10"
(node:64123) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
(Use `node --trace-deprecation ...` to show where the warning was created)
gyp info spawn /opt/homebrew/opt/[email protected]/bin/python3.10
gyp info spawn args [
gyp info spawn args '~/Documents/Github/nteract/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '~/Documents/Github/nteract/applications/desktop/node_modules/zeromq/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '~/Documents/Github/nteract/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '~/Library/Caches/node-gyp/18.4.0/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=~/Library/Caches/node-gyp/18.4.0',
gyp info spawn args '-Dnode_gyp_dir=~/Documents/Github/nteract/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=~/Library/Caches/node-gyp/18.4.0/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=~/Documents/Github/nteract/applications/desktop/node_modules/zeromq',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
CXX(target) Release/obj.target/zmq/binding.o
../binding.cc:28:10: fatal error: 'zmq.h' file not found
#include <zmq.h>
^~~~~~~
1 error generated.
make: *** [Release/obj.target/zmq/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (~/Documents/Github/nteract/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack at ChildProcess.emit (node:events:537:28)
gyp ERR! stack at ChildProcess._handle.onexit (node:internal/child_process:291:12)
gyp ERR! System Darwin 22.2.0
People will definitely get tripped up by all the zmq dependencies they need for their system.
Branch | Build failing π¨ |
---|---|
Dependency | rxjs |
Current Version | 5.3.1 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
rxjs is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you itβs very likely also breaking them.
I recommend you give this issue a very high priority. Iβm sure you can resolve this πͺ
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot π΄
iopub
should not be a subject. It should only be an Observable
.onCompleted
, still a subject.subj.send = subj.onNext
to fit our intent rather than RxJS's parlance. I like this better so people can write shell.send(payload)
. Somebody once told me that adding props at runtime is a performance drag. Once I see that being an issue, we can adapt it.onNext
ahem send
on.Branch | Build failing π¨ |
---|---|
Dependency | sinon |
Current Version | 2.3.4 |
Type | devDependency |
This version is covered by your current version range and after updating it in your project the build failed.
As sinon is βonlyβ a devDependency of this project it might not break production or downstream projects, but βonlyβ your build or test tools β preventing new deploys or publishes.
I recommend you give this issue a high priority. Iβm sure you can resolve this πͺ
The new version differs by 8 commits.
33f32ac
Update docs/changelog.md and set new release id in docs/_config.yml
d00ab2b
Add release documentation for v2.3.5
1c690aa
2.3.5
cc0a3fb
Update Changelog.txt and AUTHORS for new release
ef2ecec
Check configurable on a prop before creating (fixes #1456) (#1462)
e7dbfd7
Merge pull request #1460 from gj/patch-1
512018f
Fix minor typos
d60d4a2
Fix apostrophe typos (#1454)
See the full diff
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot π΄
Branch | Build failing π¨ |
---|---|
Dependency | rxjs |
Current Version | 5.4.0 |
Type | dependency |
This version is covered by your current version range and after updating it in your project the build failed.
rxjs is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you itβs very likely also breaking them.
I recommend you give this issue a very high priority. Iβm sure you can resolve this πͺ
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot π΄
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.