Giter Club home page Giter Club logo

Comments (4)

tpodolak avatar tpodolak commented on June 30, 2024

@dtchepak I am trying to add valid test case for this scenario and I came up with this

using NSubstitute;
using System;
using Xunit;

namespace MyNamespace
{
    public class Foo
    {
        public event Action SomeEvent;
    }

    public class FooTests
    {
        [Fact]
        public void Test()
        {
            var substitute = NSubstitute.Substitute.For<Foo>();
            substitute.Received().SomeEvent += Arg.Any<Action>();
        }
    }
}

However, this test passes, even though SomeEvent was not fired - according to docs
it is one of the way of asserting if event subscription was received. Is this valid test case in this case or there is regression in NSubstitute?

from nsubstitute.analyzers.

dtchepak avatar dtchepak commented on June 30, 2024

This is because the member is not virtual. Running multiple tests including this one gives me:

  Error Message:
   NSubstitute.Exceptions.RedundantArgumentMatcherException : Some argument specifications (e.g. Arg.Is, Arg.Any) were left over after the last call.

If it is virtual it fails as expected.

  Error Message:
   NSubstitute.Exceptions.ReceivedCallsException : Expected to receive a call matching:
        SomeEvent += any Action
Actually received no matching calls.

from nsubstitute.analyzers.

tpodolak avatar tpodolak commented on June 30, 2024

Ahh right. I dont know why I thought that events were handled differently. Will update my PR accordingly

from nsubstitute.analyzers.

jm-atbas avatar jm-atbas commented on June 30, 2024

Can you release an update with this fix to NuGet, please?

from nsubstitute.analyzers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.