False positive on NS5000 when received method is static. about nsubstitute.analyzers HOT 3 OPEN

Hi @GraniLuk
Static methods can not be substituted - see more in docs. One way or another, can you provide full example? Your snippet doesnt seem to be valid c#, as you cant call static method on instance of the class - so maybe we are facing other issue here.

from nsubstitute.analyzers.

Hi @tpodolak
It's about static extension methods, they can be checked with Received, but it throws a warning with latest update. Here is example of using IMemoryCache.
using Microsoft.Extensions.Caching.Memory;
using NSubstitute;
using NUnit.Framework;
using System.Threading.Tasks;

public class TestExample{

[Test]
public async Task WhenIbanNotFoundInCache_ReturnsFromHttpCallAndStoresInCache()
{
    var _memoryCache = Substitute.For<IMemoryCache>();
    var sut = new ExampleClassWithMemoryCache(_memoryCache);

    sut.InvokeMemoryCache();

    _memoryCache.Received(1).Set("key", "value");
}

}

public class ExampleClassWithMemoryCache
{
private readonly IMemoryCache _memoryCache;

public ExampleClassWithMemoryCache(IMemoryCache memoryCache)
{
    _memoryCache = memoryCache;
}

public void InvokeMemoryCache()
{
    _memoryCache.Set("key", "value");
}

}

from nsubstitute.analyzers.

Thanks for full example. Extension methods follow the same rules as static methods so they cannot be substituted. In certain cases however, extension method substitution might work - but this is considered a hack rather than documented behavior. Please take a look at #170 where this is explained in details by @dtchepak

from nsubstitute.analyzers.