nrel / atb-calc Goto Github PK

Extractor.py's metadata functions don't read in the number of tech details. We may be able to use the length of the meta table to determine the number of tech details.

Running the following with default config results in AssertionError: Net Capacity Factor (%): First year should be 2021, got 2020 instead.
procWind = LandBasedWindProc(atb_electricity_workbook, crp=crp, case=financial_case); procWind.run()

Updating the config BASE_YEAR = 2020 results in AssertionError: ITC schedule not found in tax credit data. Looking for "ITC Schedule/*" in:

Any advice? I'm using the "2022 v3 ATB Mid-year update 2-15-2023.xlsx" workbook.

          > A couple questions/comments about UtilityPVPlusBatteryProc.

1. It uses a custom extractor, but that extractor is not being used in `extract_test_data.py`. Is UtilityPVPlusBattery being adequately tested?

Good question. The reason for the custom extractor is to allow for specifying the tax credit case during processing. So we're adequately testing the PTC+ITC case, but not the "ITC only" case. We'd have to do some upgrades to extract_test_data.py and test_lcoe_calculator.py to cover both cases.

Originally posted by @brtietz in #19 (comment)