npwd-community / npwd_crypto Goto Github PK

View Code? Open in Web Editor NEW

7.0 2.0 10.0 258 KB

License: GNU General Public License v3.0

TypeScript 91.85% Lua 0.39% HTML 0.86% JavaScript 6.90%

npwd_crypto's Introduction

NPWD Crypto

External NPWD app for buying, selling and trading crypto currency.

Screenshots

Setup and Configuration

Framework is automatically detected for ESX and QBCore

Installation

Download the latest from the release or build from source.

Download the npwd_crypto.zip from releases. DO NOT CHANGE THE RESOURCE NAME.
Unzip and add the resource to your server resources folder
Ensure npwd_crytpo BEFORE npwd
Add the app to NPWD config.json in the apps section "apps": ["npwd_crypto"]

ESX ONLY

Use Latest ESX legacy as of commit c00ff2365820c6edb4146e0c357fc3ea5247b304
Add crypto as to Config.Accounts in esx_extended/config.lua:

Config.Accounts = {
	bank = {
		label = _U('account_bank'),
		round = true
	},
	black_money = {
		label = _U('account_black_money'),
		round = true
	},
	money = {
		label = _U('account_money'),
		round = true
	},
	crypto = {
	    label = "Crypto Currency",
	    round = false
	}
}

Config

{
  "maxHistory": 10,  // Maximum number of data points to store in history
  "logging": {
    "enabled": false, // Enables discord webhook logging of crypto price updates
    "webhook": "" // Discord webhook link
  },
  "tick": {
    "min": 15, // Minimum value the crypto can take
    "max": 250, // Maximum value
    "upDownRatio": 0.6, // [1.0-0.0] chance for crypto to go up
    "maxDeviation": 10, // Maximum amount the price can go up or down
    "interval": 15, // Time in minutes for each price change
    "crashChance": 0.05 // Chance% for price to reset to minimum
  }
}

Development

If you wish to make changes or build yourself you can clone the repository with git clone https://github.com/npwd-community/npwd_crypto.git then install the dependencies with yarn build or npm i.

You can either build the project with yarn build or alternatively, you can use yarn watch to put webpack in watch mode so that it will automatically rebuild after any changes you make.

npwd_crypto's People

Contributors

Stargazers

Watchers

Forkers

itschip ckaysone380 cptnohand mycroft-studios casperg267 monkey1995 asaayu iqfiskmos backsh00ter gekkebult

npwd_crypto's Issues

Bug: PECFL Crypto purchases are Unknown. #

Cryoto purchases or sales are showing as Unknown ## in transaction logs for PECFL

ESX Rounding

Known: ESX will round the amounts of coin when transferring

Issue created in ESX repo: esx-framework/esx_core#421

Make it possible to use real Crypto values

Make it posible to use an API key for live crypto values like in qb-crypto

Cant read properties of undefined

https://gyazo.com/e33f026ddad27b4982039e2833819518

Cannot read property toString of null

Hello, keep getting this error on latest crypto & esx as well as latest npwd built (both scripts are built, not releases, but happens with release too). Didn't happen before I updated to latest esx I believe (few commits before rounding for each currency)

image preview of the error

Feature Request: Close dialogues on submit

When clicking on the confirm button it doesn't close the smol input page and i think it probably should tbh

Feature Request: Transaction Fees

~~[1]~~

~~Unfortunately, cannot do much in JS/TS so proposing this is best I can do, unless there are events sent out when selling / buying.~~

~~Make it so the bit value is followed by real life crypto (doesn't have to be real time, atleast estimated), perhaps give an option to choose from couple of cryptos to follow.~~

I've just read the closed issue that you declined it already, so yeah.

[2]
Add selling fee so people cannot buy & sell without any reduction (also to lower economy a bit :D)

[ script:npwd_crypto] [npwd_crypto] ERROR: No framework detected

I use esx legacy wiht ox inventory, what am i doing wrong?

this is my config:

{
"maxHistory": 10,
"logging": {
"enabled": false,
"webhook": ""
},
"tick": {
"min": 15,
"max": 250,
"upDownRatio": 0.6,
"maxDeviation": 10,
"interval": 15,
"crashChance": 0.05
}
}

Ability do disable "Buy" option

This would be good, if a server uses crypto for buying rare items and crypto can only be optained via crypto sticks.

Sell exploit still an issue

Good morning , The sell exploit rate limiter hasn't worked. The issue seems to be when they input more than 3 decimal places. For example 1.333 is fine but one 1.3333 causes an issue where it bugs out and allows them to keep selling . I've attached a video link to help with explaining what i mean , I think closing the sell UI and or limited text input to 2 decimal places would solve this issue.

2022-09-17.11-29-57.mp4

BUG: Application can't be loaded

It's impossible to load the application, I've tried loading it after npwd and before, I 've even started it before anything else. Each time I get this code.

Failed to load external app "npwd_crypto". Make sure it is started before NPWD. (webpack-internal:///69747:13109)
[object Event] (webpack-internal:///69747:13110)

I've tried rebuilding it myself, but same there nothing changes.

[BUG?] ESX Crypto displaying rounded balance?

Hello, I'm not sure if it's intended, but crypto is always showing rounded number and never float. Is it intentional? Screens below, I think they're self-explainatory