Giter Club home page Giter Club logo

placenames's People

Contributors

cnrdh avatar filchos avatar pierrecagne avatar rdux avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

pierrecagne

placenames's Issues

API v1 vs v2

What to do?

"updated": "2020-12-13T16:30:05.504Z",
"updated_by": ""

https://v2-api.npolar.no/placename/feature/ca6d36fc-e7ce-5f28-b70c-9090befb0d3c
vs
https://v2-api.npolar.no/placename/feature/ca6d36fc-e7ce-5f28-b70c-9090befb0d3c/_info

{
"id": "ca6d36fc-e7ce-5f28-b70c-9090befb0d3c",
"type": "application/json",
"dir": "/placename/feature/",
"owner": "[email protected]",
"size": 1046,
"version": "v2.0.0",
"rights": {
"[email protected]": {
"read": true,
"update": true,
"delete": true
}
},
"created": "2020-06-30T07:38:17.332Z",
"modified": "2020-12-13T16:30:05.679Z",
"released": "2020-06-30T07:38:17.332Z"
}

Vindegga, DML is duplicated

{"name":"Vindegga","id":"892fb9f9-97dc-51cd-b471-3adb764a761f","point":[-3.7833333,-72.95,0],"terrain":{"nn":"fjell","en":"mountain"},"area":"Dronning Maud Land","ident":903166}
{"name":"Vindegga","id":"ccbd7375-2250-5385-9790-4ac3c0b5b5ef","point":[-3.7833333,-72.95,0],"terrain":{"nn":"fjell","en":"mountain"},"area":"Dronning Maud Land","ident":902461}

Filtering search results for cases

If one were to add v2params.set("facet", "area") in src/cases-search/cases-search-url.js, one would have the filter for areas under the seqrch box in the 'case' tab of the application. However, no fetch request is done when clicking on a filter value, which result in the page staying as such (no rerender triggered by the change of the list of results).

This is strange because the case search tab follows the same exact recipe than the placename search tab, based on the same SearchAny lit-element... I can't understand the bug after half a day trying to track it. All I know is that:

  1. the url of the webpage is correctly modified
  2. if reloading the page after clicking a filter, one gets the expected ouputs (so I would say routing is not in question)
  3. the method this.searchURL is only triggered at connectedCallback, but not when clicking a filter value
  4. the API is not fetch after clicking a filter value
  5. the exact same actions on the placename tab has the expected results...

Because it is working on the placename tab, I want to dismiss the possibility that the bug is in SearchAny. But the CaseEdit lit-element is then so simple that the solution should be obvious.

Data issues AQ DML

NOT country AQ but area Antarktis
33f7dd70-3432-51b0-b468-bf600a91efc7 {"@value":"Axel Heibergs Bræ"}
622f0191-9b5c-5d4c-870b-9114c4c01547 {"@value":"Bettys Top"}
8264a14b-1986-545c-857c-ac2a17fb79db {"@value":"Framheim"}

Slash
"Lazarev, naučnaja stancija /SSSR/"
"Roi Baudouin /Belg./"
"Mizuho /Nip./"
"Lazarev, nauchnaja stancija /SSSR/"
"Amundsen-Scott /USA/"
"SANAE /S.Afr./"
"Novolazarevskaja, nauchnaja stancija /SSSR/"
"Norway /Nor./"
"Syowa /Nip./"
"Maudheim, /Nor./"
"Plateau /USA/"

Issues from @todo

Placenames @todo

Known bugs/missing features/flaws

  • no load more / paging
  • Just white on 0 results
  • Links with & breaks: ?q=Giles+&+Rep+1710=
  • link rel canonical missing
  • Imperfect sync of name-cases and case-placenames
  • robots.txt allows too much (search engine results)
  • no sitemap.xml
  • possible to create blank names and duplicate names
  • no sorting of search results

@todo DELETE https://github.com/npolar/placenames/blob/master/todo.md :)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.