nozaq / shogi-rs Goto Github PK

This will make generating all possible moves a way simpler.

Refs: #13

I appreciate that you've been maintaining the great library. I'm trying to write some code to solve tsume shogi with this.

It seems that unmake_move doesn't decrement a piece count of the type which was captured by the move, but it should. Unmaking such moves with captures adds extra piece in the game every time.

Reproduction code

use shogi::{Move, Position, Color, Piece, Square};
use shogi::bitboard::Factory as BBFactory;
use shogi::piece_type::PieceType;

fn main() {
    BBFactory::init();
    let mut pos = Position::new();
    let sfen = "8l/8+R/8k/9/9/9/9/9/9 w r2b4g4s4n3l18p 1";
    pos.set_sfen(sfen).unwrap();
    assert_eq!(1, pos.hand(Piece{piece_type: PieceType::Rook, color: Color::White}), "initial");
    pos.make_move(Move::from_sfen("1a1b").unwrap()).unwrap();
    assert_eq!(2, pos.hand(Piece{piece_type: PieceType::Rook, color: Color::White}), "after make_move");
    pos.unmake_move().unwrap();
    assert_eq!(1, pos.hand(Piece{piece_type: PieceType::Rook, color: Color::White}), "after unmake_move");

thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `2`: after unmake_move', src/main.rs:47:5
stack backtrace:

The position used for the example in KIF format:

後手の持駒：飛　角二　金四　銀四　桂四　香三　歩十八　
 ９ ８ ７ ６ ５ ４ ３ ２ １
+---------------------------+
| ・ ・ ・ ・ ・ ・ ・ ・v香|一
| ・ ・ ・ ・ ・ ・ ・ ・ 龍|二
| ・ ・ ・ ・ ・ ・ ・ ・v王|三
| ・ ・ ・ ・ ・ ・ ・ ・ ・|四
| ・ ・ ・ ・ ・ ・ ・ ・ ・|五
| ・ ・ ・ ・ ・ ・ ・ ・ ・|六
| ・ ・ ・ ・ ・ ・ ・ ・ ・|七
| ・ ・ ・ ・ ・ ・ ・ ・ ・|八
| ・ ・ ・ ・ ・ ・ ・ ・ ・|九
+---------------------------+
先手の持駒：なし

I found that parsing of pieces in hands doesn't properly handle the case when the number of pieces are 10 (2 digit number) or more. In this example, White should have 17 Pawns, but it results in 7:

use shogi::{Move, Position, Color, Piece, Square};
use shogi::bitboard::Factory as BBFactory;
use shogi::piece_type::PieceType;

fn main() {
    BBFactory::init();
    let mut pos = Position::new();

    let sfen = "7k1/9/7P1/9/9/9/9/9/9 b G2r2b3g4s4n4l17p 1";
    pos.set_sfen(sfen).unwrap();
    assert_eq!(pos.hand(Piece{piece_type: PieceType::Pawn, color: Color::White}), 17, "pawn count");
}

thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `7`,
 right: `17`: pawn count', src/main.rs:15:5

parse_sfen_hand seems to omit leading digits.

serde_cbor is unmaintained

The serde_cbor crate is unmaintained. The author has archived the github repository.

Alternatives proposed by the author:

• ciborium
• minicbor

See advisory page for additional details.

There are some broken links in crate documentation.

• shogi
  • http://www.geocities.jp/shogidokoro/usi.html
• Bitboard
  • http://chessprogramming.wikispaces.com/BMI2#PEXTBitboards
  • http://chessprogramming.wikispaces.com/BMI2
• TimeControl
  • https://en.wikipedia.org/wiki/Time_control#Japanese_byo-yomi (URI id doesn't work)
  • https://en.wikipedia.org/wiki/Time_control#Compensation_.28delay_or_increment_methods.29 (URI id doesn't work)

The workflow lint.yml is referencing action actions/checkout using references v1. However this reference is missing the commit a6747255bd19d7a757dbdda8c654a9f84db19839 which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

I appreciate that you've been maintaining the great library. I'm trying to write some code to solve tsume-shogi with this.

I'm looking for an efficient way to generate legal Drop moves. I'm trying to consider the area only around of king's position so that I don't have to try make_move() for useless drop moves.
So I'm happy if the pos.find_king() method is public and available.

https://github.com/sugyan/tsumeshogi-solver/blob/0.1.0/dfpn-solver/src/lib.rs#L190-L263

Is there any reason why this method is currently private?

my blog: https://memo.sugyan.com/entry/2021/11/11/005132

How would you figure out if a player has won in a position?