novemog / banchonet Goto Github PK

View Code? Open in Web Editor NEW

6.0 1.0 1.0 1.24 MB

An osu! bancho server implementation written in C#

License: MIT License

C# 100.00%

aspnet bancho c-sharp dotnet osu

banchonet's People

Contributors

Stargazers

Watchers

Forkers

folate

banchonet's Issues

Check for beatmap status updates if it is not ranked

Our system does not take into account that beatmap status can be updated without md5 being changed. It probably should be checked before returning beatmap from our cache/db.

Pinned scores

Infrastructure for player's pinned scores

Processing the rest of server packets

EntityFramework query does not return anything but sql does

None of these queries return anything with EF but using this not commented query in - for example - phpmyadmin it returns elements that I want.

BanchoNET/Services/Repositories/Scores.cs

Lines 71 to 76 in 8e8c4a3

 var scores = await dbContext.Scores 

 .FromSqlRaw($"SELECT * FROM Scores WHERE PlayerId IN ({string.Join(", ", playerIds)}) AND PlayTime > TIMESTAMP(\"{date:yyyy-MM-dd}\", \"{date:HH:mm:ss}\")") 

 .ToListAsync(); 

 /*var scores = await dbContext.Scores 

  .Where(s => playerIds.Contains(s.PlayerId) && s.PlayTime > date) 

  .ToListAsync();*/

I was thinking about storing every played ranked mania keymode separately. Rankings would still be a summarized version of every keymode (main mania profile too) but we will be able to show different stats for every keymode.

Unicode characters crashing the server

While testing functionality of sending messages I checked if I could send some Unicode characters to other players. It crashed (?) the server or didnt process at all the message with those characters. This should be investigated further.

EDIT:
Instead of crashing the server it just "disconnects" client and stops sending any packets at all. It is also impossible to log in after that.

EDIT 2:
Fixed by encoding length of BYTE ARRAY instead of string length...

	var scores = await dbContext.Scores
	.FromSqlRaw($"SELECT * FROM Scores WHERE PlayerId IN ({string.Join(", ", playerIds)}) AND PlayTime > TIMESTAMP(\"{date:yyyy-MM-dd}\", \"{date:HH:mm:ss}\")")
	.ToListAsync();
	/*var scores = await dbContext.Scores
	.Where(s => playerIds.Contains(s.PlayerId) && s.PlayTime > date)
	.ToListAsync();*/