novavoidhowl / cvrfury Goto Github PK

Need warning in UI of parameterStreamLink so that if a user sets a non-global parameter as the target then a waring is shown

Dynamic Bone, seems it hates being in a prefab and needs to be re-added/re-configured after game objects are re-parented, it does retain its settings, but the related bones end up being way off position wise like 800 units away from the model.

Note, fix for Magica Cloth 2 (already implemented) may be a good base for this

need to have a stage during module install cleanup that removes scripts components that could cause that

If multiple active avatars in the scene have DSUs on objects under them, then it appears that only the last one in the list will get processed

if a DSU is has no modules set, but is on an object under the avatar, then it can cause processing to hang (and the module processing window to get stuck)

When there are two or more armature links per DSU then the paths end up stacking in the created animation clips.
eg

 - curve:
      serializedVersion: 2
      m_Curve:
      - serializedVersion: 3
        time: 0
        value: {x: 0, y: 0, z: 0}
        inSlope: {x: 0, y: 0, z: 0}
        outSlope: {x: 0, y: 0, z: 0}
        tangentMode: 0
        weightedMode: 0
        inWeight: {x: 0, y: 0.33333334, z: 0.33333334}
        outWeight: {x: 0, y: 0.33333334, z: 0.33333334}
      m_PreInfinity: 2
      m_PostInfinity: 2
      m_RotationOrder: 4
    path: skeleton/hips/spine/chest/shoulder_l/upperarm_l/forearm_l/hand_l/CVRF_Addon_0/[CVRF_D0]_Clock/hips/CVRF_Addon_0/[CVRF_D0]_Hip/HipRotation/HeadClone/Monitors/Keyboard

Sometimes menus have menus under them in VRCFury are setup such that one menu has another under it (nested menus)
Need to add processing that flattens this out for the CVR menu structure

per the above image the bounding box for addon meshes can get messed up.
need something to counteract this

If there are many animation clips/paths to rewrite, this can take some time and it may appear that process has hung.
Would be good to add some sort of progress indication for playmode (its more obvious in build mode due to unity progress bar behavior)

re the 3.10 CCK experimental build (ref branch experimental-3.10cck) the FullController installer needs updating to cope with the new definitions in 'dropdownParameter' (CVRFuryMenuStore)

lines 11480, 1200 & 1224 are directly impacted by this, but code section needs full review to support this new class structure

If AFK is found in animator then mention need for https://github.com/kafeijao/Kafe_CVR_Mods/blob/master/BetterAFK/README.md
Primarily for the AFK bool (which does not exist natively in the Parameter stream)

Need auto detection of use of IsLocal in the generated animator, as a cleanup step so that a layer can be added to set that bool based on #DeviceMode + parameter stream

note that IsLocal will have to be auto converted to #IsLocal on all layers as that is how CVR tags local variables

Need animator write defaults fix step, as mix of write defaults on/off can break animations across the whole avatar (resulting in it being locked in the motorcycle pose)

if a state is missing an animation (ie when used just for behaviors) is can cause the avatar to end up stuck in the motorcycle pose

need to add a fixer that checks all layers for missing 'no action' animations (not on states that host blend trees)

This is to allow for items to be put in multiple places, ie. left or right arm/leg etc. based on the proximity of the bone to the item
Support for this is there in the DSU code (avatarTargetingMode 2 AKA proximity ), and the hook exists in ModuleInstaller_ArmatureLink.cs (line 2327), but there is no implementation of the feature yet.

as can be seen it only seems to get to one of the modules, then trips the failsafe/null DSU trap

Animator processing needs to find and re-write VRCAvatarParameterDriver into the equivalent CVR component AnimatorDriver

if a game object on the avatar is disabled the DSUs on it are not detected during module install phase.

looks like an multi async problem, as the module installer itself process is a coroutine
need some way to hold the CCK task while the installer does its tasks