Missing API functions related to SpyCall about sinon HOT 4 OPEN

The one I followed previously is not the newest version.

I have not checked other missing function precisely, but I am pretty sure the newest Sinon.js changed and added lots APIs. Since I contributed part of new version's SinonJS document.

Feel free to list those new features you think can benefit this library, I am willing to extend current library :)

from sinon.

• spyCall.calledOn # Returns true if obj was this for this call.

During the time I implement Sinon.py, I didn't implement any function related to scope this, because the concept of scope between Javascript is totally different from Python. (JavaScript is a functional programming language, however, Python is a OOP language.)

For example:
In JavaScript, there is closure concept => without bind(this):

Obj = {
    foo: function() {console.log("foo")},
    bar: function(runThisFunc) {runThisFunc()},
    baz: function() {
        this.bar(function() {
            this.foo()
        })
    }    
}
{foo: ƒ, bar: ƒ, baz: ƒ}
Obj.baz()

You will got this error.

Uncaught TypeError: this.foo is not a function

However, in Python

class Obj:                                                                                                         
    def foo(self):
        print("foo")
    def baz(self):
        def func(): self.foo()
        self.bar(func)
    def bar(self, run_this_func):
        run_this_func()

o = Obj()
o.baz()

It won't give any error.

Thus based on the difference between Python and JS, I didn't implement this feature.

from sinon.

Thus based on the difference between Python and JS, I didn't implement this feature.

That's a good point. Conversely, it makes sense to add some things to Sinon.PY, like kwargs. I will update the issue.

from sinon.

You are right, kwargs is a tricky thing in Python.

There are some part of my code need to be refactored about kwargs and args.

Because, for any function call of object, while it called by args, the first arguments will be object itself, later the arguments. On the other side, while it called by kwargs, the first arguments will be called argument.

For example:

class Obj(object):
   def func(a=0, b=0, c=0):
       pass
o = Obj()
o.func(1,2,3)
# args is (Obj, 1, 2, 3)
o.func(a=1, b=2, c=3)
# args is (Obj), kwargs is {'a': 1, 'b': 2, 'c': 3}

But, the above might meet some exception in some edge cases based on current implementation

I think there is a way to split args into 2 part, one for module/class, the other for pure args.

Also, this needs big efforts too, it impacts several places.

from sinon.