Giter Club home page Giter Club logo

Comments (2)

note35 avatar note35 commented on June 17, 2024

In python3, this code works.

In python2, it will cause the error below.

Traceback (most recent call last):
  File "test.py", line 10, in <module>
    print(stub()) # error
  File "/Users/kir/python-dev/sinon/sinon/lib/base.py", line 135, in __call__
    return self._get_wrapper()(*args, **kwargs)
TypeError: unbound method wrapped() must be called with A instance as first argument (got nothing instead)

from sinon.

jonathan-benn avatar jonathan-benn commented on June 17, 2024

I suspect that this bug may have existed for a long time, since it's kind of the opposite of the issue that required the dirty hack in the first place.

The problem is that when trying to directly execute a class method (a class, not an object), Python is expecting the self argument as the first parameter to the function call.

Hence, the following code passes:

class A:
	def B(self):
		return 5
stub = sinon.stub(A, 'B')
stub(A()) # success!

This is because, as a language feature of Python, if you're calling the function B directly without an object then you must supply an instance. e.g.

o = A()
A.B(o) # returns 5

I'm not sure what you think the right thing to do would be in this case? One could consider the current behaviour of Sinon.PY to be correct. However, I do find it counter-intuitive (confusing) to need to pass an object instance into the stub.

from sinon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.