norman-tom / pyromb Goto Github PK

Hi Tom,

Just tested the plugin, but GE support feature doesn't work for me. The pyromb version has updated to 0.2, but it seems an error occurred:
A:\QGIS 3.28.5>pip install --upgrade pyromb Requirement already satisfied: pyromb in a:\qgis 3.28.5\apps\python39\lib\site-packages (0.1.0) Collecting pyromb Downloading pyromb-0.2.0-py3-none-any.whl.metadata (6.2 kB) Downloading pyromb-0.2.0-py3-none-any.whl (25 kB) Installing collected packages: pyromb Attempting uninstall: pyromb Found existing installation: pyromb 0.1.0 Uninstalling pyromb-0.1.0: Successfully uninstalled pyromb-0.1.0 Successfully installed pyromb-0.2.0 WARNING: There was an error checking the latest version of pip.

Not sure if it is the reason.
Thanks for your effort. I appreciate it.

Regard,
Theo

RORB requires a single outlet. This is represented by setting the 'out' attribute of the confluence to one. If there are multiple confluences with the attribute set to one, the pyromb will select the out location as the first feature it encounters with the out attribute as one.

To avoid this confusion, pyromb should check that there is only a single 'out' attribute set to one, if not throw an error and advise the user.

After obtaining a .catg file from "Build RORB" in QGIS, I noticed that the areas of the subareas from the .catg file and the shp file, don't match. This is the same problem for the example files provided for Build RORB (QGIS). Why is this the case?

Hi Tom, I tried to use this cool tool but got stuck on finding the runoff model plugin. Has it been published yet?

The graphical information section of the RORB .catg was not parsed correctly by the RORB GUI when the length of the reach labels was greater than eight characters. For example, the .catg file that did not parse correctly was labelled with reaches of the format "S122-J235", this caused RORB to failed and throw an error when loading. Once the reaches were labeled to a character length of a maximum of 4 the catg file parsed correctly.

vector.txt

Pyromb assumes that the id field for reaches, confluences and centroids are globally unique. The dictionary that holds the ids to map these to an integer id required by RORB is shared across the three entities, therefore when these ids are not globally unique the order of connection is disrupted and RORB fails to build the catg file.

Solution is to use separate dictionaries, one for the reaches, confluences and centroids and only require unique ids within each dataset.

When parsing empty gis attributes which are required to build the vector correctly does not throw an error and returns 'None' in the catchment vector which would cause errors in RORB.

The required attribute names should be checked, and a clear error reported back to the user indicating which attributes are missing from which shapefile.

Hi Norman,

Thank you for developing plugin for RORB. However when I try to install the plugin, it gives the following error. Could you please help me to fix this. I am using QGIS version 3.22.4

Thank you and appreciate your help

Hi Tom,
I tried to use my own files, but got some issues as title said. Could you please take a look?
The files are: https://github.com/Global-Citizen/runoff-model-test-file