Giter Club home page Giter Club logo

elm-sweet-poll's People

Contributors

allenap avatar avh4 avatar lukewestby avatar mthadley avatar stoeffel avatar tesk9 avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar

Forkers

supercipher

elm-sweet-poll's Issues

Make Config easier to update?

We want to initialize the Config data with custom settings.

Based on UpdateResult data, we want to be able to change our Config data (we need killswitches and interval changes to apply to sessions that are already polling, and we might want to change what URL we poll against).

Given the existing APIs:

init : Config data -> ( PollingState data, Cmd (Msg data) )
...
defaultConfig : Decoder data -> String -> Config data
...
update : Config data -> Msg data -> PollingState data -> UpdateResult data

This leads to hard-to-follow code:

init flags =
  let
        pollingConfig =
            SweetPoll.defaultConfig decodePollingData (Url.toString flags.pollingUrl)
                |> (\c -> { c | delay = flags.pollingData.pollingIntervalMs })

        ( pollingState, pollingCmd ) =
            SweetPoll.init pollingConfig
  in
  (   { polling = ( pollingConfig, pollingState )
      }
    , if flags.pollingData.pollingEnabled then
        Cmd.map PollingMsg pollingCmd

      else
        Cmd.none
   )

update msg model =
    case msg of 
       PollingMsg pollingMsg ->
           let
                ( config, state ) =
                    model.polling

                { newState, newData, error, cmd } =
                    SweetPoll.update config pollingMsg state
            in
            case ( newData, error ) of
                ( Just pollingResult, Nothing ) ->
                    ( { model
                        | polling =
                            ( { config | delay = pollingResult.pollingIntervalMs }
                            , newState
                            )
                      }
                    , if pollingResult.pollingEnabled then
                        Cmd.map PollingMsg cmd

                      else
                        Cmd.none
                    )

                ( _, Just e ) ->
                    ( model
                    , Cmd.none -- log error
                    )

                ( Nothing, Nothing ) ->
                    ( model, Cmd.none )

Could storing the config on the sweet poll state help?

Then we could provide helpers like:

kill : PollingState data -> PollingState data
setInterval : Int ->  PollingState data -> PollingState data 
setUrl : String ->  PollingState data -> PollingState data

and the other functions could change such that:

init : Decoder data -> PollingState data
update : Msg -> PollingState data -> UpdateResult data

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.