Giter Club home page Giter Club logo

emacs's People

Contributors

fmnoise avatar geekerzp avatar gguimaraesbr avatar jdek avatar justbur avatar kaiwk avatar meqif avatar purcell avatar reilysiegel avatar rien333 avatar svengreb avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

emacs's Issues

mu4e support

Implement support for the built-in ๐Ÿ“ฆ MU4E mode.

Theme does not load with `emacs --daemon`

If emacs is started with emacs --daemon, the nord theme will not properly load, but will instead display as grey-on-white; there are many messages like the following:

Unable to load color "brightblack"
Unable to load color "brightcyan"
Unable to load color "brightblack" [5 times]
Unable to load color "brightblack"
Unable to load color "brightcyan"
Unable to load color "brightblack" [2 times]
Unable to load color "brightcyan"
Unable to load color "brightblack" [5 times]
Unable to load color "brightcyan"
Unable to load color "brightblack" [2 times]
Unable to load color "brightcyan" [3 times]
Unable to load color "brightblack"
Unable to load color "brightcyan"
Unable to load color "brightblack"
Unable to load color "brightcyan"
Unable to load color "brightblack" [5 times]

I believe that this is because in daemon mode there is no terminal, and thus nothing to send the colour names to. I think that the fix is to use the color class system as documented in Defining Faces.

Theme customization: Region Highlight Style

Resolves #32

Description

A theme customization should be added to allow users to set a style for the region highlighting either to snowstorm or frost, providing a way for users to adjust the colors to fit their needs.

The default should be left to nord2 as background- and no specific foreground color.

The customization should be available through the nord-region-highlight variable of type string.

Usage

Example using the snowstorm style:

(setq nord-region-highlight "snowstorm")

Theme customization: Custom Comment Brightness

Introduction

The low contrast color of comments is by design of Nord and has been selected specifically to not disturb code flow and keep the focus of the developer on the code. It is totally fine that users not agree to all highlighting color assignments, everyone has different preferences. That is the reason why themes exist ๐Ÿ˜„

Anyway, since I've got a bunch of tickets on various port projects with requests to increase the comment contrast I want to make sure the theme is adaptable to fit everyone's needs, even if I'm not going to change the default color.

In most cases the problem can be solved by using local overrides to adjust specific parts of the theme like I proposed in arcticicestudio/nord-vim #26 or arcticicestudio/nord-emacs #23, but providing a official theme customization is the optimal way to achieve this.

Description

A accessibility theme customization should be added to allow users to set the brightness of comments with percentage adjustments from 0% - 20% where 0 is the default nord3 comment color. When a invalid value is passed (< 0 || > 20 || nil) the default nord3 color should be used.

The customization should be available through the nord-comment-brightness variable.

This should be a optional customization to provide a way for users to adjust the color to fit their needs. It should be a port of the reference implementation from the Nord Atom Syntax project. The values should be calculated using the LESSCSS lighten function to ensure full interoperability with other port projects that providing this theme feature.

Increased by Calculated value
0% (default) nord3
1% #4e586d
2% #505b70
3% #525d73
4% #556076
5% #576279
6% #59647c
7% #5b677f
8% #5d6982
9% #5f6c85
10% #616e88
11% #63718b
12% #66738e
13% #687591
14% #6a7894
15% #6d7a96
16% #6f7d98
17% #72809a
18% #75829c
19% #78859e
20% #7b88a1

Usage

Example to increase the comment color brightness by 15%:

(setq nord-comment-brightness 15)

Add a light variant

Wow, this theme is gorgeous and well executed. Excellent work!

But have you considered a light variant (light background) of this theme?

Migrate to MIT license

Subtask of nordtheme/nord#55

Adapt to the MIT license migration of the main Nord project. Detailed information can be found in the main task ticket.

Tasks

  • Update all license SVG badges
  • Update the LICENSE.md content
  • Update- and simplify all source code comment header

Region/selection background color is unlike the default region highligh in the README

Hello there and thanks a lot for the awesome colorscheme!

In Emacs, I'm getting region selections highlighted like this:

image

I've tried configuring it "back" to default with (setq nord-region-highlight "default"), which is a bit silly, but I keep getting the pink selection highlight.

Why might this be? I want it to look like in the README:
image

Environment:

echo $TERM
screen-256color

emacs --version
GNU Emacs 26.1

The terminal emulator is Termite.
The terminal theme is Nord as well.

Decorators highlighting in python

What about the highlighting of Python decorators with color different from classes and methods?
For example screenshots from Emacs (first) and Visual Studio Code (second)

image
image

Main theme library

Implement the main theme library nord-theme.el.
It should support all standard / basic UI- and syntax faces.

Magit Support

Some Magit commands still displaying default colours, e.g. magit-log-current

left margin matches left char with global-linum-mode

emacs

When there is a button flushed left and global-linum-mode is enabled, the button extends into the left margin (where the linums exist).

The theme leuven has the same problem. Most of the other themes I have seen do not try to do this.

Is this something that the theme should turn off? I couldn't find what setting it would be...

Thanks

Nord colors for org habits consistency graph

Some themes use theme colors for the org habits consistency graph (in the org agenda view), which is a lot more pleasant than seeing theme colors everywhere, but bright red, bright yellow, etc, in the habits graph. I imagine this is as simple as linking four or five color names together, and would be a big improvement for me and others that use org mode.

Python docstrings are very pale

Docstrings in python are not readable if not to establish illumination of the display on a limit. Is it possible to make it a little more noticeable?
image

Support polymode

Thanks for this wonderful theme, very relaxing!

Do you have any plan to support polymode? Polymode allows to have multiple major modes in the same buffer, as a series of chunks from one mode or the other. It can be very useful for Org files, or Markdown files with YAML headers, or any combination using R (RMarkdown, R knitr, etc.). As it is now, "embedded" chunks are on a very light background, which makes them almost impossible to read. See for instance, a very simple example of RMarkdown (i.e. R chunks in a Markdown file):

screenshot from 2017-11-13 15-25-27

The light background should ideally be gray, just a bit lighter than the normal gray background so that it's noticeable.
I'd be happy to help figuring it out, but I'm not exactly sure where to start (I have no knowledge of theming or the mechanisms of faces in Emacs).

Using degraded color (avoid using color name)

I use emacsclient on both terminal and gui and I use after-make-frame-functions to reload nord-theme when open a new frame to correct the color. But if I have a GUI frame opened and tried to open emacsclient on terminal, it will crash immediately because there are no definition for bright colors on emacs GUI. Can we use something similar to solarized's solarized-term-color to avoid using "bright*" color name?

Comment Color Brightness

Bound to nordtheme/nord#94

This issue will implement the increase of the comment color (nord3) brightness by 10% from a lightness level of ~35% to ~45%.

โžœ Please see nordtheme/nord#94 for all details about this design change decision.

โš ๏ธ NOTE: This will also deprecate the custom comment brightness configuration because it won't be necessary anymore for users to increase the brightness on their own.
A deprecation warning will be added to notify all users who have set a custom value for the nord-comment-brightness configuration variable.

Comments are hard to read

Nord is lovely, but I'm finding it hard to read comments with them set to nord3:

nord3

What do you think about changing it to nord9? I can create a PR with the change if you're happy with it, but if everyone prefers the de-emphasized current scheme then I'll just change my local copy:

nord9

Point is very hard to see

Nice theme!

The current version on melpa, 20170325.2314, has an almost invisible point as seen in this screenshot:
screenshot_20170403_192528

nord-theme leaks unprefixed names to the global environment

Sadly, Emacs Lisp has no namespaces, so every top level definition is visible to the entire universe. That includes variables and functions.

The current nord-theme defines one of each, nord-brightened-comments and brightened-comment-color, which are leaked.

The former is ... ok, though not best practice. The later has a chance of conflicting with anything else that uses a similar global name, and is definitely not in line with best practices for Emacs code.

Add license header keyword

Related to #40

Add a license header keyword to help tools to automatically detect the license type as used by GitHub and Emacsmirror (licensee).

;; License: Apache-2.0

show-paren-match face not themed in Emacs 26

Came across this while adapting my config for Emacs 26.2 coming from 25.3

It seems as if something changed between Emacs versions 25 and 26 wrt. how the names of faces are parsed, which causes the following lines to work fine in Emacs 25, but not 26:

https://github.com/arcticicestudio/nord-emacs/blob/9ed7b9c2d1bb68ae86d06f97d215d2883e4ff0d2/nord-theme.el#L273-L274

seemingly due to the names of the faces not actually having the -face suffix.

The same is the case for running M-x customize-face RET show-paren-match-face RET - works in 25, not 26, even though the face is really called just show-paren-match in both.

In my local nord-theme.el on my Emacs 26 installation, I tried changing show-paren-match-face to just show-paren-match (same for -mismatch), and then it worked. I'm not sure if these are the only faces affected by this.

Theme customization: Uniform Mode Lines

Related to #32

Description

A theme customization should be added to allow users to enable uniform activate- and inactive mode lines using nord3 as background. The default should be left to nord1 as background color.

Default mode lines - Different background colors for active- and inactive mode lines

This option should make use of contrast difference by using different background colors for active (focused windows)- and inactive (unfocused windows) mode lines.

Uniform mode lines - Uniform background colors for active- and inactive status lines

This option should make use of the same background color for active (focused windows)- and inactive (unfocused windows) mode lines to achieve a uniform style while the nord8 foreground color indicates which window is focused.

The customization should be available through the nord-uniform-mode-lines variable of type boolean.

Usage

(setq nord-uniform-mode-lines t)

Wrong color in terminal

I'm trying to use this theme on my personal emacs configuration. But colors are not correct if I opened emacs in a terminal.

  • OS: Linux Sirius 4.18.4-arch1-1-ARCH #1 SMP PREEMPT Wed Aug 22 07:33:26 UTC 2018 x86_64 GNU/Linux
  • Terminal: gnome-terminal with nord-theme (I've also tried tilix with nord-theme, and the result is the same).
  • $TERM = xterm-256color
  • GNU Emacs 26.1
  • Emacs setup code:
(use-package nord-theme
  :demand
  :config
  (progn
    (load-theme 'nord t)))

Emacs UI

2018-08-24-093730_950x1043_scrot

Emacs Terminal

2018-08-24-093806_950x1043_scrot

I've used other theme until now, one from doom-themes and it worked the same in terminal and ui version. Am I missing any configuration?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.