nomorepanic / token_auth Goto Github PK

The library is reading from a private field of the Plug.Conn struct, which is not there anymore in newer Plug versions (I encountered the problem on version 1.7).

Suggestion:

• Use another way to look up this information which does not rely on an implementation detail of Plug.
• Do not run any check at all if the exclude: option is not used.

Thanks for this cool library! 😃

In the current implementation, the token and realm are read from the configuration at compile-time. This is a problem for any applications which are deployed using e.g. a release, as here the environment in which the app is compiled is not the same as the environment in which it will be run.

Instead of using module attributes, it is probably better to look up the values either on every request (as the overhead is very low) or if optimization really is desired when the plug is initialized.