nokkbl / khubkhao-recommender Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 3.0 1.06 MB

Link to our demo project webpage:

Home Page: https://khubkhao-rec.herokuapp.com/

Python 76.31% HTML 22.62% Makefile 0.55% CSS 0.52%

khubkhao-recommender's People

Contributors

Stargazers

Watchers

Forkers

tsuttive driveiei vichacorn

khubkhao-recommender's Issues

Set Django project to load seed data.

Learn how to interact between Django & React

Manage database for each food

The currently selected criteria (category) is not checked on results page.

User selected a food category and click "Submit".
It shows matching foods, but does not show which boxes
were checked.
Look at Amazon or Lazada.
After you select some criteria that filter the results,
the criteria selected are checked on the results page.

Write unit test for database(seed).

Pictures didn’t show up in homepage

Add more foods data to JSON file.

Improve controllers to handle invalid requests.

Learn about seed database in Django

Votings

Vote one rating for many menus and the rate point should decrease but it increase instead.

Use of decouple.config() fails if you don't have a .env or setting.ini file

You don't have default values for KKR_USER_DB, KKR_PWD_DB, etc,.
so even if the user has python-decouple on his machine, Django will
fail when config('KKR_USER_DB') is invoked.

I think there is a more clever way to use decouple.config() than what you are
doing. Look at the module docs page.

Improve README.md

Too many installation step

it maybe not necessary to do every step in order to run locally for now.

Write controllers for food to filter category and ethnic food.

Add security into production.

Installtion: undocumented dependencies on 'decouple' and 'django_heroku'

When I tried to install your app according to installation instructions I got this error:

ImportError: No module named 'decouple'

Looks like you are using decouple.config( ) to get some environment variable.

If you are going to use decouple, you could save users a lot of editing of
settings.py by providing separate .env files for local configuration and Heroku
configuration. You aren't using config() fluently for the database URL.
See example on https://henriquebastos.net/python-decouple-2-2-strict-separation-of-settings-from-code/

Write test controllers correctly handle both valid and invalid requests.

Error initializing database

I followed the instructions for installing your app locally
(after corrections for previous issues) but on the step:

python manage.py loaddata seed.json

it throws the following error:

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/django/core/serializers/python.py", line 100, in Deserializer
    data[Model._meta.pk.attname] = Model._meta.pk.to_python(d.get('pk'))
  File "/usr/local/lib/python3.5/dist-packages/django/db/models/fields/__init__.py", line 945, in to_python
    params={'value': value},
django.core.exceptions.ValidationError: ["'cate1' value must be an integer."]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "manage.py", line 15, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/base.py", line 316, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/base.py", line 353, in execute
    output = self.handle(*args, **options)
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/commands/loaddata.py", line 72, in handle
    self.loaddata(fixture_labels)
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/commands/loaddata.py", line 113, in loaddata
    self.load_label(fixture_label)
  File "/usr/local/lib/python3.5/dist-packages/django/core/management/commands/loaddata.py", line 168, in load_label
    for obj in objects:
  File "/usr/local/lib/python3.5/dist-packages/django/core/serializers/json.py", line 69, in Deserializer
    yield from PythonDeserializer(objects, **options)
  File "/usr/local/lib/python3.5/dist-packages/django/core/serializers/python.py", line 102, in Deserializer
    raise base.DeserializationError.WithData(e, d['model'], d.get('pk'), None)
django.core.serializers.base.DeserializationError: Problem installing fixture '/home/projects/FoodRecommender/khubkhaoapp/fixtures/seed.json': ["'cate1' value must be an integer."]: (khubkhaoapp.category:pk=cate1) field_value was 'None'

Write unit test for food in each category

Learn frontend unit test

Write unit test for frontend part

Learn Django, unit test, and Django rest framework

Remove unused code

If you don't use these code, please delete them.

khubkhao-recommender/khubkhaoapp/tests.py

Lines 1 to 19 in 29ef474

 # from django.http import HttpRequest 

 # from django.test import TestCase 

 # from django.urls import reverse 

 # class IndexPageTest(TestCase): 

 # def test_home_page_status_code(self): 

 # response = self.client.get('/') 

 # self.assertEquals(response.status_code, 200) 

 # def test_view_uses_correct_template(self): 

 # response = self.client.get(reverse('index')) 

 # self.assertEquals(response.status_code, 200) 

 # self.assertTemplateUsed(response, 'khubkhaoapp/index.html') 

 # def test_home_page_contains_correct_html(self): 

 # response = self.client.get('/') 

 # self.assertContains(response, '')

Improve code in controllers (Clean code).

Remove unused code

khubkhao-recommender/khubkhaoRec/settings.py

Lines 148 to 149 in 2ee29d5

 # STATICFILES_STORAGE = 'whitenoise.storage.CompressedManifestStaticFilesStorage' 

 STATICFILES_STORAGE = 'django.contrib.staticfiles.storage.StaticFilesStorage'

delete old STATICFILES_STORAGE.

	# from django.http import HttpRequest
	# from django.test import TestCase
	# from django.urls import reverse


	# class IndexPageTest(TestCase):

	# def test_home_page_status_code(self):
	# response = self.client.get('/')
	# self.assertEquals(response.status_code, 200)

	# def test_view_uses_correct_template(self):
	# response = self.client.get(reverse('index'))
	# self.assertEquals(response.status_code, 200)
	# self.assertTemplateUsed(response, 'khubkhaoapp/index.html')

	# def test_home_page_contains_correct_html(self):
	# response = self.client.get('/')
	# self.assertContains(response, '')

	# STATICFILES_STORAGE = 'whitenoise.storage.CompressedManifestStaticFilesStorage'
	STATICFILES_STORAGE = 'django.contrib.staticfiles.storage.StaticFilesStorage'