Giter Club home page Giter Club logo

bongo's People

Contributors

66leo66 avatar github-actions[bot] avatar greg-21 avatar justliliandev avatar lordgrimmauld avatar masik16u avatar melanx avatar noeppi-noeppi avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar

Forkers

lordgrimmauld king5462 greg-21 nevoka-be yay899 justliliandev dummdumm247 keipg pulset1 66leo66 tbiscuit1 oohshuhnmaahn cooliojazz audunvn sirlinkos masik16u mindbomber2 rinkore elihumauricio

bongo's Issues

Text "Bingo Item" disappears from all items and blocks

Currently, there are max 25 items and blocks on the bingo card. Each of them has the text "Bingo Item" in its tooltip. When you obtain any of the required items or blocks in any way, the text "Bingo Item" disappears but not only from the item or block you've just obtained but from all of them. It shouldn't behave like this, I think.

For more context, look at these pictures and their descriptions:

  1. At first:
    Tooltip-at-first
    As you can see in this picture, both stone and granite have the text "Bingo Item" in their tooltips (as they are on my bingo card, among others of course).

  2. Afterwards:
    Tooltip-afterwards
    After picking up only one of them (e.g. stone), the text "Bingo Item" disappeared from both tooltips, but should've disappeared from only one of them (i.e. from stone, since I picked up only it). I don't think it should behave like this, hence my issue report.

This issue occurs on the following configuration (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo version: 1.0.4
  • LibX version: 1.0.6
  • Forge version: 35.1.4

[Suggestion] 13 task win condition

A 13 task win condition and the lockout setting could then be used to create a game mode via a datapack that would allow a lockout where whichever team gets over half the tasks would win (this would only really be useful if playing with 2 teams)

[1.20.1] [Forge] Biome tasks fail to validate

Hello!

Adding the latest version of the mod (Bongo-1.20.1-4.0.1) to a Forge 47.0.35 server gives the error below in the log.
Fortunately, this doesn't affect the mod's default tasks and settings.
But it does affect you if you try adding a datapack that changes the settings (again, changing only the settings, not also the tasks) and it fails to load it giving the same error.

[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:plains
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:desert
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_hills
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:taiga
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:swamp
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:river
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:frozen_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:stony_shore
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:birch_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_gravelly_hills
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:nether_wastes
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:the_end
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:frozen_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jagged_peaks
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:mushroom_fields
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_savanna
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:stony_shore
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_beach
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:badlands
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:wooded_badlands
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:warm_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:lukewarm_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_lukewarm_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_cold_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_frozen_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:sunflower_plains
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_gravelly_hills
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:flower_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:ice_spikes
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:bamboo_jungle
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:soul_sand_valley
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:crimson_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:warped_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:basalt_deltas
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:plains
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:desert
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_hills
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:taiga
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:swamp
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:river
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:nether_wastes
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:birch_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:badlands
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_lukewarm_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_cold_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_frozen_ocean
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:soul_sand_valley
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:crimson_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:warped_forest
[20:34:50] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:basalt_deltas

Some entity models twitch slightly

When you take a closer look at the entity models on the bingo card, you can see that some of them twitch slightly (some a little more (marked by "*"), others less) for some reason, while they don't do so when spawned with no AI in the game world.

The twitching entities include at least:

  • a dolphin
  • a hoglin*
  • a llama
  • a piglin*
  • a piglin brute*
  • a rabbit
  • a trader llama

This issue occurs on the following configuration (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo version: 1.0.4
  • LibX version: 1.0.6
  • Forge version: 35.1.4

Enhancement - Potion Effects

It will be super cool if you can set different potion effects that players will have at the start of any game. For example, since teleportation can take a bit of time and it's not done simultaneously, I like to give my players 30 seconds of Slowness II, so nobody can move until everyone has spawned. Currently I'm doing this using command blocks, but having it in a settings file would be much more efficient and easier for people who create their own games. ^^

Thanks!

[1.12.1-4.0.1] Custom datapack settings not getting applied

Hey there,

I made a custom datapack with some different options, but seemingly some are not getting applied correctly. I can select the options when I create a new bingo game, but some parts from the game section aren't working (i.e. invulnerable, lockout, leaderboard and time from my testing). The teleport radius works correctly.

I'm using the mod version Bongo-1.20.1-4.0.1 with LibX-1.20.1-5.0.5.

These are the setting I tired to use:

{
  "game": {
    "win_condition": "bongo.default",
    "invulnerable": false,
    "pvp": false,
    "friendly_fire": false,
    "time": "3600",
    "consume_items": false,
    "lock_task_on_death": true,
    "teleports_per_team": 0,
    "leaderboard": true,
    "lockout": true
  },
  "level": {
    "teleporter": "bongo.default",
    "teleport_radius": 1000
  },
  "equipment": {
    "inventory": [],
    "backpack": [],
    "emergency": [],
    "offhand": {
      "item": "minecraft:air",
      "count": 0
    },
    "head": {
      "item": "minecraft:air",
      "count": 0
    },
    "chest": {
      "item": "minecraft:air",
      "count": 0
    },
    "legs": {
      "item": "minecraft:air",
      "count": 0
    },
    "feet": {
      "item": "minecraft:air",
      "count": 0
    }
  }
}

Here is an excerpt from the startup log:

[...]
[23:03:52] [main/INFO] [cp.mo.mo.LaunchServiceHandler/MODLAUNCHER]: Launching target 'forgeserver' with arguments []
[23:03:59] [modloading-worker-0/INFO] [ne.mi.co.ForgeMod/FORGEMOD]: Forge mod loading, version 47.1.0, for MC 1.20.1 with MCP 20230612.114412
[23:03:59] [modloading-worker-0/INFO] [ne.mi.co.MinecraftForge/FORGE]: MinecraftForge v47.1.0 Initialized
[23:03:59] [modloading-worker-0/INFO] [Dynmap/]: [Dynmap] Mod Support API available
[23:03:59] [Forge Version Check/INFO] [ne.mi.fm.VersionChecker/]: [bongo] Starting version check at https://assets.melanx.de/updates/bongo.json
[23:04:00] [Forge Version Check/INFO] [ne.mi.fm.VersionChecker/]: [bongo] Found status: BETA Current: 1.20.1-4.0.1 Target: null
[23:04:00] [Forge Version Check/INFO] [ne.mi.fm.VersionChecker/]: [libx] Starting version check at https://assets.melanx.de/updates/libx.json
[23:04:00] [Forge Version Check/INFO] [ne.mi.fm.VersionChecker/]: [libx] Found status: BETA Current: 1.20.1-5.0.5 Target: 1.20.1-5.0.5
[23:04:00] [Forge Version Check/INFO] [ne.mi.fm.VersionChecker/]: [forge] Starting version check at https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json
[23:04:00] [Forge Version Check/INFO] [ne.mi.fm.VersionChecker/]: [forge] Found status: OUTDATED Current: 47.1.0 Target: 47.2.0
[...]
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:plains
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:desert
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_hills
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:taiga
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:swamp
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:river
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:frozen_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:stony_shore
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:birch_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_gravelly_hills
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:nether_wastes
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:the_end
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:frozen_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jagged_peaks
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:mushroom_fields
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_savanna
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:stony_shore
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_beach
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:badlands
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:wooded_badlands
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:warm_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:lukewarm_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_lukewarm_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_cold_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_frozen_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:sunflower_plains
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_gravelly_hills
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:flower_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:ice_spikes
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:bamboo_jungle
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:soul_sand_valley
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:crimson_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:warped_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:basalt_deltas
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:plains
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:desert
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_hills
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:taiga
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:swamp
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:river
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:nether_wastes
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:birch_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:badlands
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_lukewarm_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_cold_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_frozen_ocean
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:soul_sand_valley
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:crimson_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:warped_forest
[23:04:16] [Server thread/ERROR] [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:basalt_deltas

I think that's everything related to bongo, hope I didn't miss something.

JEI itemgroup

Group all items in the current bingo in a jei item group. Then you could search for all items in the current bingo like this ^bingo. Maybe also groups for every row / columns (^bingo_r1 or ^bingo_c3)

Biome-dependent vegetation is always gray

Biome-dependent vegetation that doesn't have its own icons and uses a rendered 3D model instead is always gray. It looks like your mod uses some sorts of heightmaps only.

For comparison, in vanilla Minecraft the same vegetation is displayed correctly (e.g. in inventory), with some specific color. Maybe you could see how Mojang did it and implement it in your mod as well.

Screenshot showing this issue:
Gray-vegetation

This issue occurs on the following configuration (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo version: 1.0.4
  • LibX version: 1.0.6
  • Forge version: 35.1.4

[1.20.1-4.0.2] The configuration option "invulnerable" does not take full effect.

According to the description in custom-bingos.md, the "invulnerable" option allows the player to resist most damage and automatically restore the player's Hunger Value.
However, when I actually played the game, I found that this option did not seem to be fully effective, but only helped me to automatically restore my Hunger Value, and did not make me immune to any other damage.

Mod version : 4.0.2
The logs :
https://mclo.gs/QZXpsYH
The setting I use :

{
  "game": {
    "win_condition": "bongo.default",
    "invulnerable": true,
    "pvp": false,
    "friendly_fire": false,
    "time": "unlimited",
    "consume_items": false,
    "lock_task_on_death": false,
    "teleports_per_team": 0,
    "leaderboard": false,
    "lockout": false
  },
  "level": {
    "teleporter": "bongo.default",
    "teleport_radius": 10000
  },
  "equipment": {
    "inventory": [],
    "backpack": [
      {
        "item": "minecraft:stone_sword"
      },
      {
        "item": "minecraft:wooden_sword"
      }
    ],
    "emergency": [],
    "offhand": {
      "item": "minecraft:air",
      "count": 0
    },
    "head": {
      "item": "minecraft:air",
      "count": 0
    },
    "chest": {
      "item": "minecraft:air",
      "count": 0
    },
    "legs": {
      "item": "minecraft:air",
      "count": 0
    },
    "feet": {
      "item": "minecraft:air",
      "count": 0
    }
  }
}

does not work

26.05 07:24:31 [Server] Startup Done (4.604s)! For help, type "help"
26.05 07:24:31 [Server] Server thread/INFO [ne.mi.se.pe.PermissionAPI/]: Successfully initialized permission handler forge:default_handler
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:ocean
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:plains
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:desert
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_hills
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:forest
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:taiga
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:swamp
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:river
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:frozen_ocean
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_ocean
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:stony_shore
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:birch_forest
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna_plateau
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:cold_ocean
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_gravelly_hills
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:nether_wastes
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:the_end
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:frozen_ocean
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jagged_peaks
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:mushroom_fields
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:beach
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_savanna
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:windswept_forest
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:jungle
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:deep_ocean
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:stony_shore
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_beach
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:dark_forest
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:snowy_taiga
26.05 07:24:31 [Server] Server thread/ERROR [bongo/]: Failed to validate task of type bongo.biome: Biome not registered: minecraft:savanna
26.05 07:24:33 [Multicraft] Skipped 43 lines due to rate limit (40/s)
26.05 07:25:05 [Server] User Authenticator #1/INFO UUID of player Rahim_191 is eff3d95b-b7d8-40f3-b33c-4add475a1168
26.05 07:25:07 [Server] Server thread/INFO [ne.mi.co.AdvancementLoadFix/]: Using new advancement loading for net.minecraft.server.PlayerAdvancements@5ef44baf
26.05 07:25:07 [Connect] User Rahim_191, IP 51.223.34.40
26.05 07:25:07 [Server] Server thread/INFO Rahim_191 joined the game
26.05 07:25:07 [Multicraft] Rahim_191 ran command Message of the Day
26.05 07:26:42 [Server] Netty Epoll Server IO #1/ERROR Error receiving packet 36

Check marks and X marks are displayed under entity models

Green check marks (completed tasks) and red X marks (locked tasks) are displayed under entity models on both the regular Bingo card and the big one.

Screenshots showing this issue:
Check-marks-and-X-marks
As you can see in these screenshots, only entity rendering seems to be problematic (however, for some reason some entity models are not affected on the regular Bingo card), all other types work correctly.

This issue occurs on the following configurations (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo versions: 1.0.4, 1.0.10 from Maven
  • LibX version: 1.0.7
  • Forge version: 35.1.4

Regenerate game for each game

Add a configurable option to regenerate the world for every game. Maybe implement this by using custom dimensions so that it's easy to modify worldgen.

Add an Ignore NBT option

Bongo only consider items that has an identical NBT, this include no-NBT

Because of that, items that can have NBT data inside of them will become invalid for completion, this include :

Potions
Tools/Armor that aren't full durability or that has enchants
Filled Maps
Written Books
Fish/Axolotl Buckets
Named Item
Banners

Adding a "Ignore NBT" condition would fix this problem

Here is an exemple (while it is custom, it happens on non-modified bongo)
image
In this case, I have a stone axe, but since it lost 1 durability, it won't count

Edit: Reformated my message

Enhancement - Creating games

Would be awesome if the /bingo create parameters were separated. firs you will need to set the settings (/bingo settings) that will remain as set unless you run another /bingo settings changing the parameters. Then you use the /bingo create to set the card (easy, normal, hard, customs). That way is possible to players to create a Lobby to configure any and all possibilities using separated command blocks.

Hope you like the idea! Thanks :)

[Suggestion] Some compatibility ideas.

I'm creating a vanilla modpack using some QoL mods that can benefict from some compatibility with Bongo. Most of them are purely cosmetic.

Add REI/EMI Compat. Dont know how difficult can this be already having JEI compat (and not sure if it worth it) but would be cool to be able to have any recipe viewer.

ItemPickup (and Legendary Tooltips). This is maybe the less usefull since it will consist in adding the required items to the pickup list so only the items in the bongo card will show up on pick up. As I said, this cannot be very useful, but i think it can be cool. I will add a config to disable this feature since players might want to have all displayed.

AdvancementPlaques. Similar to what happends with ItemPickup and ItemBorders, but for Advancements.

Jade. If possible, would be cool if Jade shows a different style when looking a block/item that is in the bongo list.

ItemBorders. Same as ItemPickup, but this one has more utility since it can be very handy when you must keep all your bingo items in order to claim the victory.

Quark/Shocase Item. if any of this mods is installed, it will be cool to have the item showcased in the chat once a player completes the task.

Xaero's/Journey Maps (and bingo lobby, tell me if I should add this to the corresponding GitHub). Would be cool if waypoints created during any game are removed when /bingo stop is used or the game has finished. It will make the next play so much easier.

I know this is not a priority, but ill give you this ideas so if you like them and have some free time you can add them.

Entity models are way too dark

Basically what's written in the title — entity models are rendered way too dark than they should be, making it very difficult to distinguish between entities with similar shapes without opening the big bingo card.

For a screenshot showing this issue, take a look at #12.

This issue occurs on the following configuration (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo version: 1.0.4
  • LibX version: 1.0.6
  • Forge version: 35.1.4

Allow to use custom icons

So it looks cooler

A value that points towards the texture location inside of the task and that's it I guess?

Suggestion - Effects and buffs for completing tasks

Suggestion:

Some configurable options for buffing team mates, opposing teams, or other such options.

Some examples -
One team completes a task and all opposing teams receive a buff or random buff (which is configurable)
One team member completes a task and all other members receive a buff (can be set within a time of completing another task)
Teams that are behind, when completing a task, debuff the team in the lead (set in the config)

An option for buffs and debuffs would help to even the playing field, or atleast slow other teams down, for teams with more skilled or seasoned players.

About the new items/bioms/entities in 1.19&1.20

I have been creating lots of bingos in all three tasks_ids, each of them like 20+ times, but I had not find any new items/bioms/entities in 1.19/1.20, had they been forgotten to be added

[1.20.1] Mod fails to load

Hello!

I was very excited to see that this mod was updated so quickly to 1.20, so I wanted to try it out.
At first, I put multiple quality of life mods together and the instance crashed.
Then, I created a separate instance using just:

  • FML version 47.0.34
  • Bongo - 1.20.1 - v.4.0.0
  • LibX - 1.20.1 - v.5.0.2

image

But this instance also crashes:
image

I have also attached the crash report:
crash-2023-06-27_19.56.39-fml.txt

consumeItems throws errors and makes the player who obtained a Bingo item lose connection

Bingo definitions with consumeItems set to "true" throw errors and make the player who obtained a Bingo item or block lose connection on dedicated servers. It seems that this issue doesn't occur on the internal server (or at least I weren't able to reproduce it there).

Server log showing the thrown errors:
https://pastebin.com/dqa7Bi7S

This issue occurs on the following configurations (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo versions: 1.0.4, 1.0.12 from Maven
  • LibX version: 1.0.10
  • Forge version: 35.1.4

Bongo mod not working

I have put Bongo mod in the mod menu but it does not work i downloaded mod menu to see if it was installed and it wasnt is there another mod i have to download?

Mod folder:
image

Some entity models are shifted, shrinked/enlarged, or are not rendered at all

Some entity models are shifted (mostly downwards), rendered much smaller/larger than they are in the game world, and sometimes are not even rendered at all (or at least they are rendered outside the viewport), making it impossible to knowingly kill them without opening the big bingo card.

Screenshot showing some examples:
Entities-rendering-issues

This issue occurs on the following configuration (I didn't test other configs):

  • Minecraft version: 1.16.4
  • Bongo version: 1.0.4
  • LibX version: 1.0.6
  • Forge version: 35.1.4

Jar does not contain plugin.yml

Server: Paper 1.16.5
Bongo-1.16.3-1.0.29
LibX-1.16.3-1.0.17

Error log:

[11:31:14] [Server thread/ERROR]: Could not load 'plugins/Bongo-1.16.3-1.0.29.jar' in folder 'plugins'
org.bukkit.plugin.InvalidDescriptionException: Invalid plugin.yml
at org.bukkit.plugin.java.JavaPluginLoader.getPluginDescription(JavaPluginLoader.java:162) ~[patched_1.16.5.jar:git-Paper-496]
at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:148) ~[patched_1.16.5.jar:git-Paper-496]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.loadPlugins(CraftServer.java:389) ~[patched_1.16.5.jar:git-Paper-496]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:206) ~[patched_1.16.5.jar:git-Paper-496]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:941) ~[patched_1.16.5.jar:git-Paper-496]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:175) ~[patched_1.16.5.jar:git-Paper-496]
at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.io.FileNotFoundException: Jar does not contain plugin.yml
... 7 more
[11:31:14] [Server thread/ERROR]: Could not load 'plugins/LibX-1.16.3-1.0.17.jar' in folder 'plugins'
org.bukkit.plugin.InvalidDescriptionException: Invalid plugin.yml
at org.bukkit.plugin.java.JavaPluginLoader.getPluginDescription(JavaPluginLoader.java:162) ~[patched_1.16.5.jar:git-Paper-496]
at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:148) ~[patched_1.16.5.jar:git-Paper-496]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.loadPlugins(CraftServer.java:389) ~[patched_1.16.5.jar:git-Paper-496]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:206) ~[patched_1.16.5.jar:git-Paper-496]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:941) ~[patched_1.16.5.jar:git-Paper-496]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:175) ~[patched_1.16.5.jar:git-Paper-496]
at java.lang.Thread.run(Thread.java:834) [?:?]
Caused by: java.io.FileNotFoundException: Jar does not contain plugin.yml
... 7 more

Enhancement - Nested tasks

A new task type: "nested". This new task will allow datapacks creators to nest files inside files for optimization. Imagine i have a task file named overworld.json with just items that can be found in the overworld. Then i want to create a new one, nether.json, with items found in the overworld+nether. Now i need to copy paste the code inside overworld.json and paste it in nether.json and then add new items. With the new type bongo.nested you can reference that overworld.json and the mod will automatically load everything in that json + the rest of the items in the nether.json.

I hope i made my self clear <3

Add "Negative" Task

Basicly a task that is completed by default but "uncomplete" once you do the action

Here is an exemple

You have a normal task that complete once you get a Diamond Axe
It's negative version would be that it is complete UNTIL you get a Diamond Axe, even getting rid of it WILL NOT complete it back

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.