nodeshift-archived / nodejs-configmap-redhat Goto Github PK

Problem:

API keep saying "Unable to read the configuration" though configmap does exists. The application fails to query the configmap because of permission issue. However, while applying the given role.resources also fails because of the permission issue.

Solution:

It would be nice to mount the configmap map as a volume/ENV VAR and read the configuration (preferred practice) if it fails to query the configmap.

@lholmquist

When deployed to OpenShift, this booster performs as follows:

$ curl http://ROUTE_NAME/api/greeting
{"content":"Hello, undefined from a ConfigMap !"}

it should be:

$ curl http://ROUTE_NAME/api/greeting
{"content":"Hello, World from a ConfigMap !"}

Steps to reproduce:

1. Follow instructions in docs to deploy booster, e.g. https://appdev.openshift.io/docs/nodejs-runtime.html#deploying-the-configmap-booster-using-the-oc-cli-client_configmap-oso
2. Run curl http://ROUTE_NAME/api/greeting

Reasons:

• To avoid security warnings.
• Some modern editors/linters already have the same feature.
• The project is archived https://github.com/bucharest-gold/szero.

Instead, we should just echo a message in prepare. E.g.

"prepare": "echo 'To confirm CVE compliance, run 'npm run security-check'",
"security-check: nsp check"

or something...

The devDependency tape was updated from 4.12.0 to 4.12.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tape is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on Greenkeeper branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please click the 'fix repo' button on account.greenkeeper.io.

Change the start to script to just be node . and add the main property with ./bin/www

Also change the default port from 3000 to 8080. This is related to nodeshift-archived/centos7-s2i-nodejs#33 (comment)

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

The devDependency proxyquire was updated from 2.1.2 to 2.1.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

proxyquire is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

After start , the app is not showing the address and port on the console

$ npm start

> [email protected] start /home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat
> node .

Would be good to have a basic message to quick know and access the app:

$ npm start

> [email protected] start /home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat
> node .

Server running at http://localhost:port

Got an error message affter run npm start

$ npm start

> [email protected] start /home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat
> node .

[winston] Attempt to write logs with no transports {"level":"error","message":"Error getting configThe \"path\" argument must be one of type string, Buffer, or URL. Received type undefined","stack":"TypeError [ERR_INVALID_ARG_TYPE]: The \"path\" argument must be one of type string, Buffer, or URL. Received type undefined\n    at readFile (fs.js:302:10)\n    at internal/util.js:286:30\n    at new Promise (<anonymous>)\n    at readFile (internal/util.js:285:12)\n    at retrieveConfigfMap (/home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat/app.js:90:10)\n    at Timeout._onTimeout (/home/hf/Documents/nodeshift_starters/nodejs-configmap-redhat/app.js:63:3)\n    at listOnTimeout (internal/timers.js:531:17)\n    at processTimers (internal/timers.js:475:7)"}

Create a 8.x branch and start using Node 10

• This includes updating the package.json
• Updating the application.yaml
• Add 10 to travis
• Update any Integration tests

How to run both locally and inside minishift.