Casanovo predicts for invalid spectra about casanovo HOT 3 OPEN

One solution would be to move peak processing from Dataset to Parser in depthcharge. That way invalid spectra are encountered prior to being added to the index and can immediately be filtered out, rather than when being retrieved from the dataset. As an added advantage, spectrum processing only needs to be done once for each spectrum, when creating the index, rather than repeating it every time the same spectrum is retrieved.

A disadvantage, however, is that when spectrum processing options change, the index would have to be recreated. Nevertheless, I think our spectrum processing based on best practices and we don't really vary it, so for Casanovo at least it should be pretty fixed.

Additionally, it destroys the link between the indexes of the output PSMs and the input spectra. Although this is a broader issue (#70).

@wfondrie What do you think?

from casanovo.

I'm open to this. I also think that the current way of tracking the spectrum index is pretty fragile and not ideal. Instead, that information should be saved in the index itself. Ayse started a PR in depthcharge to solve the spectrum tracking issue, but it was incomplete - I'll see if I can get it updated and integrated.

from casanovo.

#105 will address spectrum index tracking once completed for future reference

from casanovo.