Giter Club home page Giter Club logo

Comments (5)

bittremieux avatar bittremieux commented on August 26, 2024

Currently, when no config file is given, the code tries to find a default config file in the same directory as the script. If we don't package a (fully functional) config file with Casanovo, this doesn't make a lot of sense imo.

We could:

  • Include a default config file. It might be a bit challenging to come up with sensible default values for all options, but it's probably possible.
  • Change the code so that it gives a more informative error message, rather than look for a non-existing file.
  • In each case, update the documentation accordingly so that this is more clearly described.

from casanovo.

VarunAnanth2003 avatar VarunAnanth2003 commented on August 26, 2024

I updated the tutorial to tell the user how to make their own config file. However, a default already exists and it is supposed to be accessed with these lines:

if config_path == None:
        abs_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'config.yaml')
        with open(abs_path) as f:
            config = yaml.safe_load(f)

You can see the file here: https://github.com/Noble-Lab/casanovo/blob/main/casanovo/config.yaml

from casanovo.

bittremieux avatar bittremieux commented on August 26, 2024

There are two problems with the default config file:

  • It's not packaged along with the source code, so will not be available by default after installing with pip.
  • It does not always work out of the box (i.e. fails if you don't have a GPU). Especially when the config file is hidden in some internal package directory, this is challenging for people to find and modify.

from casanovo.

VarunAnanth2003 avatar VarunAnanth2003 commented on August 26, 2024

How can I modify the repo so that the config.yaml is packaged and placed in its proper place with a pip install? I'll also update the default values.

from casanovo.

bittremieux avatar bittremieux commented on August 26, 2024

You have to specify non-Python files you want included using a MANIFEST.in file.

from casanovo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.