nitrocode / cointaxes Goto Github PK

View Code? Open in Web Editor NEW

6.0 2.0 4.0 308 KB

This will make a TurboTax import file (txf) and fill out IRS form 8949 with Coinbase, GDAX, and Bittrex data

Home Page: https://bit.ly/2l8yswT

License: Other

Python 100.00%

bittrex gdax coinbase exchanges turbotax txf exchange

cointaxes's Introduction

CoinTaxes

This will fill out IRS form 8949 for the following exchanges:

Coinbase
GDAX
Bittrex data

It assumes all short term sales and will use the highest cost buy order for cost basis. This will lower the amount of taxes you will have to pay. It will make a .txf that you can import into TurboTax, and it will fill out the IRS form 8949. This has only been tested on Windows.

Enhancements

This project was forked off of CryptoTaxes by gsugar87.

Cleaned up documentation
Converted credentials.py to config.yml
Fixed code
- Updated old api functions to new ones
- Added cross platform code so it works on Windows, OSX, and Linux
- Made structure more flexible by adding exchanges package
- Added code docs
Renamed so pip package wouldn't confuse with the original project
Added an open license
See TODO.md for more details

Dependencies

pip dependencies

Using the recommended pipenv

pipenv install

pdf toolkit

Install pdftk from a binary and make sure the command pdftk is in the path.

If using Ubuntu it's easier to install.

apt-get install pdftk

Instructions

Assuming you have API keys for the exchanges you want. Edit config.yml and uncomment the exchanges and insert keys, secrets, and passphrases. Fill out your name and social in the file to have that written into the PDF.

Then finally, run the script

python CoinTaxes.py

If you have a separate configuration file:

python CoinTaxes.py --input randy.yml

Get the API credentials

Coinbase

Sign into your Coinbase account
Go to the API page and click on New API Key
In the popup window check all under Accounts:
- wallet:accounts:read
- wallet:addresses:read
- wallet:buys:read
- wallet:deposits:read
- wallet:sells:read
- wallet:transactions:read
- wallet:user:read
Click Create to see the API key and secret.

Insert the API Key into the correct variables in config.yml e.g.

 coinbase:
     key: 'abcdefg1234'
     secret: 'zxcvbasdf1234qwer'

GDAX

Sign into GDAX
Go to API page and under Permissions, check View and then click Create API Key.
Enter the two-factor authentication code if you are asked for it

Insert the API creds into the correct variables in config.yml e.g.

 gdax:
     key: 'qwerty123'
     secret: 'poiuyt999'
     passphrase: 'mnbvc000'

Bittrex

Unfortunately, the Bittrex API does not let you get your entire transaction history via an API. In order to get your entire history, you must login to your Bittrex account, go to https://bittrex.com/History, and then click on "Load All." This will download your entire history in a csv file called "fullOrders.csv". Move this file into the CryptoTaxes directory, and it will be read in.

Donate

If you find this code useful, feel free to donate!

me

BTC: 1LENSt469CoAmZBp1zSvdbSKtCacjSez3i
LTC: LbweDjdHMaHZJtkjmP11rpC7ftXYfFPKop
ETH: 0x13fc2D16fC97877Cf6C35A56F8d2e646152cc2e6
Doge: AEztxkBZ1qBDrye6o3UYphRWPNQHDUYmoW
BCH: qrf0rve9wjajr4g8h24ed3ff9kx0zqn86vlvmkyn7g

gsugar87

Original developer's crypto wallets are at the bottom of his repo.

cointaxes's People

Contributors

Stargazers

Watchers

Forkers

coolspot j0hnc0yne jeremylanglois dbjellan

cointaxes's Issues

Generates invalid TXF file

This is result TXF file:

V042
ACyrptoTaxes
D 04/16/2018
^
TD
N712
C1
L1
$1.55131499 ETH
D06/14/2017
D06/28/2017
$613.54
$453.70
^

TurboTax 2017 doesn't accept it as correct. According to specification line "$1.55131499 ETH" must be "P 1.55131499 ETH" instead.

NameError: global name 'sell_index' is not defined

After fixing #2 and #3 :

Connected to Coinbase.
Sorting the buy and sell orders by time
Traceback (most recent call last):
File "CoinTaxes.py", line 197, in
main()
File "CoinTaxes.py", line 182, in main
tax_year=config['year']
File "/home/ivan/Documents/code/CoinTaxes/formats/fill_8949.py", line 70, in get_cost_basis
print("WARNING! COULD NOT FIND A COST BASIS FOR sell_index=%d!" % sell_index)
NameError: global name 'sell_index' is not defined

It looks like variable "sell_index" was eliminated during refactoring.

TypeError: get_product_historic_rates() got an unexpected keyword argument 'product'

Ubuntu 16.04 LTS, python 2.7, ConTaxes' latest master:

Traceback (most recent call last):
File "CoinTaxes.py", line 158, in
main()
File "CoinTaxes.py", line 112, in main
exchange_buys, exchange_sells = fix_orders(exchange, exchange_buys, exchange_sells)
File "CoinTaxes.py", line 40, in fix_orders
price_usd = exchange.get_price(order['order_time'], product='BTC-USD')
File "/home/ivan/Documents/code/CoinTaxes/exchanges/gdax_reader.py", line 125, in get_price
end=order_time
TypeError: get_product_historic_rates() got an unexpected keyword argument 'product'

Exchange of an altcoin to BTC is not tracked properly causing significant 8949 profit/loss calculation mistake

For tax purposes, exchange of a $COIN to BTC is recorded as two transactions:

sell $COIN for USD
buy BTC with USD
This is handled in the function CoinTaxes.py->fix_orders().

There is a mistake that for amount of $COIN sold, the order['cost'] is used instead of order['amount'].
The order['cost'] contains amount of BTC purchased, while order['amount'] contains amount of $COIN sold.

For example, if in reality you have sold 10 ETH to buy 1 BTC, due to the error, that would be recorded as two transactions:

sale of 1 ETH for USD cost of 10 BTC
purchase of 10 BTC with USD from the above
Which significantly interferes with gain/loss and proceeds calculations.

Pyhton dependency "gdax" is deprecated

The program fails with some JSON exception because api.gdax.com endpoint doesn't exist anymore.

Negative values are not shown as (<amount>) in the result PDFs

Negative values must be formatted like (99.99), formatted as 99.99 instead.

IndexError: list index out of range in fill_8949

Traceback (most recent call last):
File "CoinTaxes.py", line 181, in
main()
File "CoinTaxes.py", line 177, in main
fill_8949.make_pdf(full_orders, "test", config['name'], config['social'], config['year'])
File "/home/user/Documents/code/CoinTaxes-2018/formats/fill_8949.py", line 169, in make_pdf
field_num = field_nums[idx - 1]
IndexError: list index out of range

TypeError: list indices must be integers, not str

Sorting the buy and sell orders by time
Traceback (most recent call last):
File "CoinTaxes.py", line 166, in
main()
File "CoinTaxes.py", line 135, in main
buys_sorted = sorted(buys, key=lambda buy_order: buy_order['order_time'])
File "CoinTaxes.py", line 135, in
buys_sorted = sorted(buys, key=lambda buy_order: buy_order['order_time'])
TypeError: list indices must be integers, not str

I suspect it was caused by fix_orders() because it appends lists instead of objects into buys and sells lists.