nithssh / sdvmods Goto Github PK

I've found that having the zoom level set to certain levels (particularly high or low extremes) causes the UI to function strangely.

When zoomed in too far, the whole UI is partly off screen, and when zoomed out too far, the date cannot be viewed on entries by mouse-over. Not to mention at any level the whole UI shifts with zoom.

Steps to reproduce

• Have e key bound to "Access Menu" (AFAIK this is the default)
• Open the "New Reminder" dialog (F2)
• Set the focus / cursor to the "Reminder Message" field
• Enter any message text that contains an e, e.g. 'island harvest ready'

Expected

The dialog accepts the message and waits for further input.

Actual

The dialog closes and the reminder is cancelled.

When I try again, sometimes I can successfully enter the message and create the reminder, but most of the time the reminder is inadvertently cancelled.

On MP Game Join throws error

error recurrs every 10m interval tick.

On attempt to set reminder throws error

Mod says it supports MP on nexusmods, please resolve or strike text

Using SMAPI 3.14.1

Pastebin error log

Supporting the mod is currently hard as there is little to no useful logging.

Steps to Reproduce:

• Press F2 set reminder text "GO TO BED"
• Select The Current Season
• Select the Day after the current day
• Check box for recurring (optional) and pick 1 day for daily reminders
• Click 1 then :30 then AM to create a 1:30am reminder
• Click Apply

What happens:

• Addon tells me 1:30am is not a valid reminder time when it is part of the vanilla SDV day-cycle and fails to set a reminder

Expected Behaviour:

• I successfully set a (recurring daily) 1:30am reminder starting the following day (technically tonight) with text "GO TO BED"

Requested Solution:

1200am / 12:30am / 1am / 1:30am should all be valid reminder times.

Potentially related / same as #12 but i read that as a AM / PM mixup not an invalid time related error.

12AM is currently understood as the noon while its supposed to be midnight. Same with 12 PM.

FIX IT, and make sure to handle 12:30 properly too.

I had an unrelated issue in SDV that caused be to have to restart the game a few times and noticed that any reminders that are triggered in a partially played day did not trigger again when the save is reloaded and that day repeated. I poked through the source to feed my curiosity and noticed that you do a straight File.Delete(filePathAbsolute) immediately after a reminder has been triggered. If you instead stored the file paths in a collection and deleted them when a new Saved event was called, the behavior would be more consistent with the rest of the games serialization systems.

I went ahead and implemented the feature in a local commit for my own use, I found several other areas that needed accommodations to compensate for this change and have been using it for a day or so. Let me know if you'd be interested in looking at any of it.

Big fan of the mod btw.