/////// leftovers in HTML code when mixed with JSX about ifdef-loader HOT 8 CLOSED

JSX code removing via comments would require that you "exit" from JSX e.g.

<div>
{
///
///<Commented_jsx></Commented_jsx>
///
}
</div>

I don't know how this can be done in #ifdef-loader, since the parser isn't aware whether you are in a JSX block or not.

from ifdef-loader.

OK this comes from the blank code method. where the code is replaced with //. This works fine for JS, but is not working well for JSX. This is most likely used to keep the same number of lines.

from ifdef-loader.

Or not :). I removed the blank code generator and shashes are still there :(

from ifdef-loader.

But the parser is run before and shall remove everything including the ifdef tags and leave nothing behind.

from ifdef-loader.

the code isn't simply removed but it's filled with /// to allow source maps to point to the original code. I don't remember why I didn't just use blank spaces instead... I vaguely remember there was a reason.

from ifdef-loader.

I addressed this in 2.2.0, now there is a new option fill-with-banks to be set in the configuration object. When true it fills with blanks (space characters) instead of //. By default it's false so it's backward compatible.

It should work with JSX as spaces are ignored.

Please let me know if that fixes your issue.

from ifdef-loader.

I saw the code. Looks good. Thank you for that.

I spotted that there is still some issue with source maps generated by webpack. For some reason, they get a lot of slashes picked probably from ifdfs. Bit hard to debug, but when I disabled source maps //// are gone.

I am not sure yet how it is possible that a source maps age getting the source with //// (I patched the offloader before to replace with spaces already)

from ifdef-loader.

I will close the ticket now as it is solved. Nothing more can be done in ifdef loader :)

from ifdef-loader.