Comments (8)
JSX code removing via comments would require that you "exit" from JSX e.g.
<div>
{
///
///<Commented_jsx></Commented_jsx>
///
}
</div>
I don't know how this can be done in #ifdef-loader
, since the parser isn't aware whether you are in a JSX block or not.
from ifdef-loader.
OK this comes from the blank code method. where the code is replaced with //. This works fine for JS, but is not working well for JSX. This is most likely used to keep the same number of lines.
from ifdef-loader.
Or not :). I removed the blank code generator and shashes are still there :(
from ifdef-loader.
But the parser is run before and shall remove everything including the ifdef tags and leave nothing behind.
from ifdef-loader.
the code isn't simply removed but it's filled with ///
to allow source maps to point to the original code. I don't remember why I didn't just use blank spaces instead... I vaguely remember there was a reason.
from ifdef-loader.
I addressed this in 2.2.0
, now there is a new option fill-with-banks
to be set in the configuration object. When true
it fills with blanks (space characters) instead of //
. By default it's false
so it's backward compatible.
It should work with JSX as spaces are ignored.
Please let me know if that fixes your issue.
from ifdef-loader.
I saw the code. Looks good. Thank you for that.
I spotted that there is still some issue with source maps generated by webpack. For some reason, they get a lot of slashes picked probably from ifdfs. Bit hard to debug, but when I disabled source maps //// are gone.
I am not sure yet how it is possible that a source maps age getting the source with //// (I patched the offloader before to replace with spaces already)
from ifdef-loader.
I will close the ticket now as it is solved. Nothing more can be done in ifdef loader :)
from ifdef-loader.
Related Issues (20)
- babel-loader complains about syntax errors in code that should be removed HOT 1
- Improve documentation to include onlyCompileBundledFiles option
- Webpack & Angular 7 HOT 7
- [Feature Request] treat undefined keys as false HOT 2
- Regular expression not working well in some cases HOT 6
- Define environment variables by default HOT 1
- Deprecation warning when used with webpack 5.0.0
- [Feature Request] Provide a way to write optional code hide in comment HOT 3
- Getting wrong line numbers: "Including lines [NaN-NaN]" HOT 2
- ifdef-loader not reflecting in main.js
- #If #endif blocks highlighting in vscode
- ESLint bad indentation HOT 2
- not working with CRLF line ending file HOT 1
- Give a option to decide whether the loader is cacheable HOT 2
- Add #define HOT 1
- ifdef-uncomment-prefix reveal_code RegExp is incorrect HOT 1
- Upgrade to webpack 5 internally
- How to config for .ts file? HOT 2
- Has anyone gotten ifdef-loader to work with Angular 13? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ifdef-loader.