ninjaman494 / hanji-android-app Goto Github PK

Show a dialog on each new update that lists changes made. This dialog would pop-up when the user opens the new update for the first time.

We got a policy violation notification from Admob:

ADS AND CONTENT OVERLAP: As stated in our Program policies, publishers are not permitted to alter the behavior of Google ads in any way. This includes placing ads so that they cover any part of the site or app content or implementing parts of a webpage to cover any portion of the ads. If your site has drop-down menus they are not permitted to cover the ads.

This violation must be fixed by Dec. 9th, or else they will disable our ads. Most likely, this violation is caused by the small banner ad on the search results page, because it can sometimes cover up search results. An enhancement we've been wanting to do for a while is to turn that ad into a card that shows up in the results list, which should also fix this violation.

Show a history of recent searches in MainActivity, under the Word of the Day card.

The favorites card isn't shown if there aren't any favorites, which makes the Conjugations Activity inaccessible. Instead, the card should be shown with a placeholder when the user has no favorites.

After making conjugation text selectable in #27, you can no longer click on them to see conjugation info. Copy and paste functionality is pretty important, so we can't just undo that PR.

Instrumented tests don't work at all, and I have no idea why or when they stopped working 😭

When implementing #35 , I forgot to the add the library I used to the Acknowledgements section. This library should be added to info_strings.xml

After closing an activity (pressing back, closing app, etc.), a fragment on this closed activity may try to open, which causes an Illegal State Exception. The most common scenario is when a user search comes up empty and they close the app before the dialog displays.

All dialogs in the app should first check if they're allowed to open before opening. This could be handled by a custom open method.

Reports:

• No Results Dialog

• Add Favorite Dialog

• Possibly caused by this

In FavoritesActivity, the addFavoriteFragment is only created once the conjugation names are fetched. If the add favorite button is clicked while the query is loading or has failed, a Null Pointer Exception will occur. This button should be disabled until the query is completed.

Crash report

Clicking on the Add Suggestion button while Display Activity is still loading the entry will cause a null pointer exception because entry is null.

Crashlytics Report 1

Crashlytics Report 2

Null pointer exception on example.sentence() in Example Adapter. We should also start logging what entry the user's looking at in Display Activity to make debugging easier. It's possible there's an entry with malformed example

Crashlytics Report

This is a very specific bug where, if onBackPressed is called while the app in the background, an IllegalStateException occurs. This happens because the Error Dialog's onDismissed listener called onBackPressed, it should be updated to finish. Other activities should also be updated accordingly.

Crashlytics Report

A lot of user suggestions are in the wrong language (i.e. English antonyms/synonyms, Spanish for example translation, etc.). We should add hints to the text fields indicating what language fields should be in.

In 1.0, Hanji would provide conjugations for a word even if it wasn't in the dictionary. 2.0 should have this same functionality.

A note should be added in the response explaining how it was conjugated.
Part of Speech will have to be deduced/assumed somehow

Edit: A better solution would be to create a separate flow for conjugationing without dictionary info, see comments

In DisplayActivity, entry, conjugations, and examples are done as three separate queries. Entry and examples are done in parallel, and then conjugations is done after the entry request is done.

It appears that the examples are already being fetched in the entry query, so the examples query is actually redundant and should be removed.

Expanding and collapsing the definitions should be animated. The existing layout should have two separate lists.

After updating to a MaterialComponents theme, the default dialog buttons color is set to colorPrimary, but we want it to be the accent color. The default AppTheme should be updated so it sets dialog buttons to the accent color using colorSecondary

When you go back to the search results (press back or home), the extended bar is out. This is correct when you're at the top of the results, but not when it returns you to the middle of them.

Possible solutions are to scroll to the top or change how extended bar handles back/home

Enable long press to copy words to clipboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update dependency com.android.billingclient:billing to v6
• Update dependency com.android.tools.build:gradle to v8
• Update dependency com.codemybrainsout.rating:ratingdialog to v2
• Update dependency com.google.android.gms:play-services-ads to v23
• Update dependency com.google.firebase:firebase-bom to v32
• Update dependency com.mikepenz:aboutlibraries to v11
• Update dependency gradle to v8
• Update dependency org.jetbrains:annotations to v24
• 🔐 Create all rate-limited PRs at once 🔐

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• Update Non-Major Dependencies (gradle, org.robolectric:shadows-httpclient, org.robolectric:robolectric, org.mockito:mockito-core, junit:junit, com.android.billingclient:billing, io.reactivex.rxjava2:rxandroid, com.mikepenz:aboutlibraries, com.codemybrainsout.rating:ratingdialog, com.google.guava:guava, com.google.code.gson:gson, com.google.android.gms:play-services-ads, com.google.firebase:firebase-bom, com.google.android.material:material, androidx.preference:preference, androidx.recyclerview:recyclerview, androidx.constraintlayout:constraintlayout, androidx.appcompat:appcompat, com.google.firebase:firebase-crashlytics-gradle, org.jacoco:org.jacoco.core, com.google.gms:google-services, jacoco)
• Update dependency com.google.guava:guava to v33

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update AndroidX Test Dependencies (androidx.test:orchestrator, androidx.test.ext:junit, androidx.test.espresso:espresso-contrib, androidx.test.espresso:espresso-core, androidx.test.espresso:espresso-intents, androidx.test:rules, androidx.test:runner, androidx.test:core)
• Update Apollo Dependencies to v2.5.14 (com.apollographql.apollo:apollo-rx2-support, com.apollographql.apollo:apollo-http-cache, com.apollographql.apollo:apollo-runtime, com.apollographql.apollo:apollo-gradle-plugin)
• Update OkHttp Dependencies to v4.12.0 (com.squareup.okhttp3:mockwebserver, com.squareup.okhttp3:okhttp)
• Update Maoni Dependencies to v10 (major) (org.rm3l:maoni-common, org.rm3l:maoni-email, org.rm3l:maoni)
• Update actions/checkout action to v4
• Update actions/setup-java action to v4
• Update actions/upload-artifact action to v4
• Update dependency org.mockito:mockito-core to v5
• Click on this checkbox to rebase all open PRs at once

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update dependency com.github.pschroen:slack-api-android to v1

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Apollo Android recently added support for batch querying, which might be useful on parts of the app where multiple requests are sent out at once (i.e. DisplayActivity). It's worth trying out this new feature to see if it improves performance.

The Feedback Activity, created by Maoni, could definitely used some UI improvements:

• Fix FAB icon color
• Change header image
• Fix text input style
• Add an optional email field so users can be contacted for further information

Even if the instrumented tests aren't working, the unit tests could definitely be automated

Originally, I thought this exception was happening because the OS force shut down the app. However, it's strange that this error is happening so often, so I think further investigation is warranted.

There should be one for each activity, but at the moment we only have tests for Conjugation and ConjInfo activities

The JSON format for favorites changed with 2.0, and any old 1.0 favorites were cleared when a user installed the 2.0 updated. However, it appears that some users still have old favorites on their phone, causing the app to crash with a serialization error.

Bug Report

We should also log shared preferences in Crashlytics reports to help use diagnose future issues.

The app uses conjugation names to fetch only the favorited conjugations from the server. This pretty efficient, but it ignores the honorific flag. The flag + conjugation name needs to be sent.

Any feedback with Korean characters in it sent through the "Report a Bug" menu shows up in Slack as "????". There seems to be an encoding problem on the Android side, as the Review messages show Korean just fine.

Currently, the extended bar is simply a view in the Relative Layout. This is works well in cases where overlap is needed, but in this activity it opens us up to a bunch of bugs. Specifically, it can cause the bar to go into the wrong state when animating. This can easily by solved by swiping down, but it looks bad. Changing the implementation to a custom Action Bar might fix it, because this functionality is already supported.

com.android.volley.TimeoutError is an error that occurs when the server takes too long to respond. It's a pretty common error that's usually caused by a bad connection, but there's no specific error message for it. Currently, the generic "something went wrong" message is used. We such should a timeout specific error message so user's know what's going on.

The conjugator option shows up for English searches. It should only show for Korean words ending in 다 (we assume that these are verbs/adjectives)

Self explanatory, having a dark mode feature would be cool. About Box and About Libraries already support it, so there actually two activities in Hanji that already have dark mode functionality.

Summary

The Word of the Day card has a button that redirects to Display Activity. Clicking on this button while the card is loading causes Display Activity to receive a null id, which makes sense because it hasn't fetched the entry yet.

The app catches this exception, so it's non-fatal. There were 22 cases of this issue from 9/5 - 10/5

Acceptance Criteria

WOD card's button is disabled until it's done loading.

Hanji's minimum api level used to be 16, but we had to raise it to 19 because of this slack library. Since we didn't want to alienate users with older phone, we now have to two versions of the app, one with api 16 and one(the newest version) with api 19. This not ideal, so we should figure out a way to bring the api level back down to 16 while still using the slack-android-api.

Determiner Past is a conjugation that's only available for verbs. If a user has Determiner Past favorited, this will cause a null pointer exception when viewing adjectives because the conjugation doesn't exist.

Crashlytics report

The reason a fork is being used in the first place was due to a bug in About Box that showed empty cards. This bug was fixed in a pull request, so we should be able to go back to using the official library.

Using the official library should also make it possible to setup Github Actions

NOTE: The latest release tag outlines some things that need to be changed for the latest version to work