nimrod46 / data-structures-and-algorithms Goto Github PK

The code for merge sorted arrays in arrays doesn't seem to work with inputs that have -ve values and are sorted like for the following input :
int[] ar1 = {-5, 3, 6, 12, 15};
int[] ar2 = {-12, -10, -6, -3, 4, 10};

Kindly check .

The 3rd function does not work as the solution. This is because you are prepopulating the hash table with all the elements in the array. So when we check the hash table to see if it contains the element in the array, the if condition is always going to be True.

The expected result for {1,5,8,5,1,8,8,7,4,4,10} should return 5 and not 1.

Hi - There's an issue with your insertion sort algorithm that arises if the same number arises in the array twice.

On line 23:

if (list.get(i) > list.get(j - 1) && list.get(i) < list.get(j))

needs to be changed to

if (list.get(i) >= list.get(j - 1) && list.get(i) < list.get(j)) and then it will sort correctly.