Add Python 3 support about stompest HOT 9 CLOSED

Hi!

I see there are a bunch of commits that introduce python 3 support that have not yet been merged to master. Are there any plans on including them and releasing a python 3 compatible version soon? Would be much appreciated!

from stompest.

This repository has only one branch master, and there are no pull requests which would introduce Python 3 support.

The situation as described above remains unchanged. I am not going to invest my own time into this issue, save review and testing, of course. Since Twisted is Python 3 compatible now, the changes should be minimal and straightforward, though, so I am inviting you and everyone else to help out with contributions.

from stompest.

OK, I'll contact the author of those commits to see if he could make a PR so that it can be included in master and released.

from stompest.

I created PR 34 which contains modifications to run stompest.core on Python 3.

from stompest.

Awesome, thank you very much! In hindsight it doesn't look like sorcery. I'll make a review; when you have made the amendments, I'll run the tests.

from stompest.

Hi,
thank you for comments and advices.
Modified version is submitted, tests passed in my environment with ActiveMQ

from stompest.

I just pushed my amendments. All tests pass; I changed some of them because I tried to make the API as harmonious between Python 2 and 3 as possible. Please have a look and comment before I go on to amend the docs and write release notes.

from stompest.

Hi,
I looked at your changes and they are fine, thank you.

from stompest.

Included in release 2.2.0 and uploaded to PyPI. Have fun and please let me know if anything is broken.

from stompest.