Comments (10)
I've renamed stompest.async to stompest.twisted as it was proposed, also had to update activemq user credentials for unit tests as it didn't work with the default empty user/pass.
I've checked the unit tests - all stompest.twisted tests have passed, but one test in stompest.core fails (test_5_integration_stomp_1_1_heartbeat).
https://github.com/sergey-sobolev/stompest/tree/develop
Anybody willing to test?
from stompest.
Thank you. That's a breaking change indeed.
Does anyone have a suggestion for an alternative to the pair of names sync/async?
from stompest.
thanks @cdunklau for reporting on behalf. i ended up using the sync version instead :(
from stompest.
@nikipore you intend to port the package to support python async? in that case you could follow the convention followed by similar async packages with aiostomp
.
from stompest.
@arjunv: I am no longer using stompest
actively, because I have moved on inside the enterprise —
who still uses stompest
in production but has no-one with both the skill and time to maintain it — to a non-coding strategic/leadership position. Therefore, it is more of a hobby, and I have to rebuild my testing and building environment from scratch every few months which rather sucks.
A few random thoughts:
- I still do accept (and test) pull requests and bugfixes, but the Python 3 port was my last big effort for stompest.
- I believe that the (half-complete) SSL/TLS capability is the most urgent improvement because I see
stompest
pretty much feature complete and stable up to Python 3.6; it displays a very low rate of found bugs indeed. - For Python 3.7, the
stompest.async
package should be renamedstompest.twisted
. If someone creates a pull request, I'll test it and rename the PyPI package accordingly. - A port to
asyncio
would make a lot of sense. If someone creates a pull request, I'll test it and create a new PyPI package. - If someone wants to take over the project, please let me know. I would actively consult as an éminence grise.
from stompest.
@arjunv it looks like you misunderstood this bug report. In case that's true, I'll be explicit:
while it appears that stompest.async
should work on versions of Python 3 that Twisted supports (3.3 - 3.6), the problem I reported is that it will just not work on 3.7+ due to the PEP 492-required change.
from stompest.
@cdunklau Actually you cannot import the package from within an async function, as I had attempted to do, which had caused the bug in my code, in the first place. This would be true for python > 3.5 and not just 3.7+. (Of course you can globally import, but I was using a custom module to install and import external packages in runtime [for a client who can't even be bothered with installing packages], which forced me to do import within an async function).
Python 3.6.4 (default, Dec 23 2017, 19:07:07)
>>> async def function():
... from stompest.async import Stomp
File "<stdin>", line 2
from stompest.async import Stomp
^
SyntaxError: invalid syntax
from stompest.
Bump, has any managed to rewrite this yet? Py3.7 is installed by default now.
from stompest.
Bump, it has been a while. I would hate to have to use an entirely differently library due to a naming issue like this.
from stompest.
from stompest.
Related Issues (20)
- ipv6 support HOT 1
- stompest consumer is slow for activemq HOT 4
- How to config exclusive=true ? HOT 4
- Messages not recieving after queue is idle for some time HOT 1
- failover option 'startupMaxReconnectAttempts' default value should be -1
- Support for asyncio HOT 2
- Asynch examples on ActiveMQ - Artemis HOT 1
- support SSL client auth in stompest.async HOT 5
- Exception <class 'select.error'>: (4, 'Interrupted system call') after upgrading stompest HOT 4
- receiveFrame does not accept a timeout parameter HOT 3
- Thread-unsafe issue if we set ack=True in SubscriptionListener HOT 3
- How to dynamically increase the number of consumers HOT 1
- Invalid SUBSCRIBE format HOT 2
- StompFrame and StompHeartBeat __str__ method returns bytes in Python 3
- failover doesn't seem to be working HOT 1
- how to get JMSXDeliveryCount in the stomp frame HOT 1
- When use version=1.2, the consumer stop to connect on topic
- collections.MutableMapping is not available in Python 3.10 HOT 7
- STOMP over websocket
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stompest.