nikibrown / bloc-grading-chrome-extension Goto Github PK

Hi @obedparla Since you updated the chrome extension to work for both platforms I'd like you to add a bit more logic for graders to conditionally include a design or dev grading signature.

I've added grading signature text for Bloc grading, Thinkful Dev grading, and Thinkful Design grading in our best practices document: https://docs.google.com/document/d/1SE0H9J60Q-SjsbW8oE_dSQ1Jkhwh0aem5u7wR23RwvE/edit#heading=h.tq9dfm7u553d

What I'm envisioning (not sure the best way to do this) is to just have a variable that the grader sets to true or false for dev grading (or design grading). Whatever is easiest - since everyone needs to go in and edit and enter their name.

Would love you know your thoughts? Thanks so much for your help with this!

Please bill this as grading time and leave a comment that this is for the chrome extension.

Hey @obedparla

So I think we need a few more controls in the options page.

These lines of code here are what I think is causing the issue:

https://github.com/nikibrown/bloc-grading-chrome-extension/blob/master/grading-msg.js#L22

isBloc and isThinkful logic does not work for the integrated platform programs. We have WDT, SDT, SET, and DT on the legacy Bloc platform (bloc.io domain), but we also have WDT and DT on the integrated platform.

The URL's for these assignments are located at lark.thinkful.com so theres no unique thing in the URL that identifies them as Bloc branded. For example https://lark.thinkful.com/grading/contacts/t:469776/assignments/2342/ This is a DT students assignment.

To solve this problem I think we need another toggle button on the options page to identify if someone is doing Thinkful grading or Bloc grading.

Let me know if that makes sense.

Once this is fixed please test by claiming checkpoints from the legacy bloc platform for both dev and design, and on the integrated platform for dev and design, and then thinkful FSF (dev) and PDF (design). Obviously, don't grade but just see if the text auto-populates the textarea.

Thanks,

N

Add standard formatting text markdown file here for praise, required changes, optional changes, additional resources too chrome extension.