niif / simplesamlphp-module-authtfaga Goto Github PK

With this module, sign in works perfectly fine (both Active Directory and OTP). For single logout, SimpleSAMLPhp do send a "success" logout message to service provider but when accessed the same URL , it directly takes to OTP page bypassing the login page for AD authentication. SimpleSAMLPhp is Identity provider in my case.

Expected Result: SimpleSAMLPhp should throw login page.
Current Result: SimpleSAMLPhp bypasses the login page and takes to OTP page.

Dear creators,
I've installed the module, enabled it and executed composer install command in the module folder..
Also added authsources section properly..
But, how can I use it? How can I start users to use it and set their authenticators?
My simplesamlphp version is 1.18.3.. The sources like for the older versions but I converted clas names to namespaces..
Still can't find how to use it..
Could you please explain it?
Thanks..

In https://github.com/NIIF/simplesamlphp-module-authtfaga/blob/master/lib/Auth/Source/authtfaga.php#L254, urlencode is called on the otpauth:// URL so it can be passed to googleapis to make a QR code. Any spaces in the totpIssuer value will not be URL encoded, so will result in a otpauth:// URL containing spaces. Google authenticator will not accept this.

Rather than urlencode, rawurlencode should be used which will convert spaces to %20.

Hi Frank,

could it be that this module is not compatibel with Latest stable version (1.14.0) of SimpleSAML? I changed two things in login.php and in general it seems to work. But the UI seems to be broken and I guess some more things are broken too. Have a look how the UI of the login page looks for me (enclosed screenshot).

Thanks,
Michael

Each DB connection issue prints DB credentials. Be aware.

Closing, added a PR.