nigma / django-session-activity Goto Github PK

View Code? Open in Web Editor NEW

62.0 62.0 10.0 318 KB

List recent account activity and sign-out from all sessions opened on other computers

License: MIT License

Python 100.00%

django-session-activity's Issues

destroy_session_activity doesn't actually destroy any session activity

destroy_session_activity doesn't actually call delete on the filtered SessionActivity.

user is None when logout is performed when already logged out

When a user is logged out, if they try to log out again then an AttributeError is raised in the following code:

def destroy_session_activity(user, request, **kwargs):
    """
    Destroy session activity record.

    Should be called when user logs out or when a session is deactivated.
    """
    session_key = request.session.session_key
    if user.is_authenticated():
        SessionActivity.objects.filter(user=user, session_key=session_key)

The user is set to None in line 101 of django/contrib/auth/__init__.py:

    user = getattr(request, 'user', None)
    if hasattr(user, 'is_authenticated') and not user.is_authenticated():
        user = None
    user_logged_out.send(sender=user.__class__, request=request, user=user)

Typo in Quickstart

"Add session_activity.middleware.SessionActivity to MIDDLEWARE_CLASSES..." should be "Add session_activity.middleware.SessionActivityMiddleware to MIDDLEWARE_CLASSES...".

Thank you for a useful app!