nielssp / csol Goto Github PK

In the way I learned to play Klondike, the player was able to have as many re-deals as they wanted. (I believe this goes for Microsoft Solitaire as well.) Perhaps there could be an option to choose the amount of re-deals allowed in a game?

When the player presses Q, this prompt appears:

The player can then make a selection with Y or N as shown in the prompt, but I've also noticed that you can press Enter to continue the game. Generally the capitalized letter in a terminal prompt means it's the default.

Consider changing the prompt to Quit? (y/N) (with a lowercase "y") to hint to the user that the the default option will be to continue the game, and can also be triggered by pressing Enter.

Note: See here for files used to recreate the bug.

If a configuration file uses the include command, any following include,
game_dir and theme_dir commands will be relative to that file, not the one executing them.

> csol -c conf1
Using configuration file: conf1
Warning: file "example" not found, searching all theme files
theme not found: 'example'

I believe this is caused by cwd of execute_file in rc.c being overridden when
the function is called recursively.

This may be caused by dirname not returning unique pointers every time or just some c jank.

Hello, Visibility like on pic

Like in title, after winning a game I noticed that there is an extra block cursor as seen on picture.
Happens for me in spider(1,2) and freecell. I use foot terminal emulator.
Not sure what info would be useful.

Here's the fix for this:

--- ui.c.orig	2020-07-04 11:49:45.000000000 +0200
+++ ui.c	2021-05-07 08:17:26.000000000 +0200
@@ -419,6 +419,7 @@
       }
     }
   }
+  nodelay(stdscr, 0);
   while (1) {
     switch (getch()) {
       case 'r':