numbers are not correctly sorted about pivottable HOT 6 CLOSED

now ok!
https://github.com/sun2rise/pivottable/blob/sort-numbers/js/pivot.js

for @nicolaskruchten
I'm quite new working on github, if i did not a nice thing branching the project i'm sorry and i will give you the code directly and you can close the branch!!

from pivottable.

with the previous commit i didn't consider multi dimensional sorting, i now fixed it!!
https://github.com/sun2rise/pivottable/blob/sort-numbers/js/pivot.js

from pivottable.

Hi there,

You seem to be fixing the Javascript version of the file rather than the Coffeescript version of the file... Actually the Javascript version is generated by compiling the Coffeescript, so changes have to be made to the pivot.coffee file. If you can describe the changes you've made which work for both numbers and strings, I would happily accept the change :)

Thanks,
Nicolas

from pivottable.

Hi nicolas,
i will try to write my mods in coffee script too today with some comment!
...and send it to THIS repository!
tnx to you, have a nice day!

from pivottable.

Hi again, I've just pushed a fix that will sort strings, numbers and strings containing numbers (i.e. dates) in a much more natural way, please let me know if this works for you :)

from pivottable.

It is working just just fine, thanks again, i think this makes a huge improvement for a wider library "use-case".
again, great work!

from pivottable.